GNOME Bugzilla – Bug 753415
Add OwnCloud Music support
Last modified: 2020-10-09 16:22:49 UTC
I guess that the resulting API would be: goa_music_get_uri() This would be used by grilo to access the Ampache instance in the OwnCloud installation.
Created attachment 323190 [details] [review] Allow storing Owncloud Ampache Password The patch allows appending ampache password to the owncloud keyring entry. There is a caveat which needs to be addressed: Canceling the password prompt dialog and then toggling the music switch again leads to a segfault because of an assertion (GOA_IS_PROVIDER) failing. I think this is because the provider pointer is freed. This is substantiated by the fact that the segfault does not occur when one manually selects the account from the TreeView on the left after canceling. I tried increasing the ref count in case the response from the dialog is not GTK_RESPONSE_OK but that doesn't seem to have an effect. Wondering if there is a way to retrieve the provider and object from the callback directly without passing a potentially freed reference.
Created attachment 323225 [details] [review] Allow storing Owncloud Ampache Password Fixes the caveat mentioned in the previous comment. Realized I had freed the struct pointer even when dialog returned a non OK response.
Created attachment 323265 [details] [review] Allow storing Owncloud Ampache Password
Created attachment 328477 [details] [review] ownCloud: Add music feature
Created attachment 328478 [details] [review] ownCloud: generate ampache password on add_account
Created attachment 328479 [details] [review] ownCloud: generate ampache password on refresh_account
Created attachment 328480 [details] [review] ownCloud: validate ampache credentials on ensure_credentials_sync The documentation for Ampache Password generation can be found at https://github.com/owncloud/music/tree/use-http-response-codes#authentication
Created attachment 328659 [details] [review] ownCloud: add RetryFeature method on_handle_retry_feature checks for "AmpacheError" key. Can perhaps be replaced with a property instead.
Created attachment 329766 [details] [review] Add uri and accept-ssl-errors proerty to Music interface
Review of attachment 328477 [details] [review]: looks good.
Review of attachment 328478 [details] [review]: looks good IMO. ::: src/goabackend/goaowncloudprovider.c @@ +1186,3 @@ + GtkBox *vbox, + GtkGrid *grid, + }, no need for this indentation.
Review of attachment 328479 [details] [review]: after this one, I'm getting segfault when cancelling the creation of an owncloud account.
Created attachment 332267 [details] backtrace
Created attachment 332388 [details] [review] ownCloud: generate ampache password on add_account
Created attachment 332389 [details] [review] ownCloud: generate ampache password on refresh_account
Something missing?
Closing in favour of: https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/issues/95 https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/merge_requests/49