After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753140 - Using LDFLAGS to add libraries causes linking error
Using LDFLAGS to add libraries causes linking error
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-01 17:14 UTC by Ting-Wei Lan
Modified: 2015-08-02 03:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Do not use LDFLAGS to add libraries (5.69 KB, patch)
2015-08-01 17:15 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-08-01 17:14:16 UTC 
We should use LIBADD and LDADD to add libraries, not LDFLAGS. Using LDFLAGS can cause wrong version of libraries to be found.
Comment 1 Ting-Wei Lan 2015-08-01 17:15:11 UTC 
Created attachment 308617 [details] [review]
build: Do not use LDFLAGS to add libraries

Libraries should be added to LIBADD or LDADD, not LDFLAGS.
Comment 2 Paolo Borelli 2015-08-01 19:44:08 UTC 
Review of attachment 308617 [details] [review]:

looks good, thanks
Comment 3 Ting-Wei Lan 2015-08-02 03:54:43 UTC 
Attachment 308617 [details] pushed as 4c18542 - build: Do not use LDFLAGS to add libraries