After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753020 - Fullscreen glitch with supertuxkart
Fullscreen glitch with supertuxkart
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: window-management
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-29 14:23 UTC by lof
Modified: 2015-07-30 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Remove fullscreen_after_placement special case (4.74 KB, patch)
2015-07-29 19:11 UTC, Rui Matos
committed Details | Review

Description lof 2015-07-29 14:23:33 UTC
When i start supertuxkart (stk) in fullscreen i get a weird glitch. Moving the window to another workspace immediately rescales stk correctly.

Video: https://imgrush.com/43BiVMB-8Eeu

You see: One window open on the current workspace. I then start stk (in fullscreen mode) on the same workspace. Weird glitch. Then i move stk's window to the empty workspace (via keys) and it changes to normal. 

It does not matter if stk is started on an empty or occupied workspace. Or if it is moved to an empty or occupied workspace. 

I run Gnome 3.14 on Debian Stable. The GPU is an Intel HD4000. The version of SuperTuxKartt is 0.9.

The terminal output of stk doesn't show anything weird apart from the " Level 2: X Error: GLXBadFBConfig".

http://paste.ubuntu.com/11959652/

Supertuxkart is a game based on a modified (fork) Irrlicht engine called Antartica.
Comment 1 lof 2015-07-29 14:28:18 UTC
The bug does not happen with other fullscreen applications. 

I tested: impress, evince, mpv, teeworlds, xonotic
Comment 2 Rui Matos 2015-07-29 19:11:47 UTC
Created attachment 308414 [details] [review]
window: Remove fullscreen_after_placement special case

This was introduced in commit c6793d477a324f857d31d0704f84ed9de0f1d680
to prevent window self-maximisation. It turns out that that bug seems
to have been fixed meanwhile in a different way since the reproducer
in https://bugzilla.gnome.org/show_bug.cgi?id=461927#c37 now works
fine with this special handling removed.

In fact, failing to set window->fullscreen immediately when loading
the initial set of X properties causes us to create a UI frame for a
window that sets _NET_WM_STATE_FULLSCREEN.

This, in turn, might cause the fullscreen constrain code to fail if
the window also sets min_width/min_height size hints to be the monitor
size since the UI frame size added to those makes the rectangle too
big to fit the monitor. If the window doesn't set these hints, we
fullscreen it but the window will get sized such that the UI frame is
taken into account while it really shouldn't (see the reproducer
above).
Comment 3 Jasper St. Pierre (not reading bugmail) 2015-07-29 20:05:43 UTC
Review of attachment 308414 [details] [review]:

Nice catch.
Comment 4 Rui Matos 2015-07-30 13:33:07 UTC
Attachment 308414 [details] pushed as 07f533f - window: Remove fullscreen_after_placement special case