GNOME Bugzilla – Bug 752818
qtdemux: add support for XML timed-text subtitles
Last modified: 2015-09-25 22:52:12 UTC
Created attachment 308070 [details] [review] Add support for XML timed-text subtitles XML timed-text subtitles are encapsulated in ISO BMFF files using the stpp sample entry type. The attached patch handles this sample entry, setting the caps of the subtitle src pad to be "application/ttml+xml". It also adds the caps "application/x-mp4-text" to the list of accepted sink pad caps, to match that used in the dashdemux patch added to https://bugzilla.gnome.org/show_bug.cgi?id=747774
Comment on attachment 308070 [details] [review] Add support for XML timed-text subtitles Caps name discussion in the other bug. sthd is not used anywhere in your patch, should it?
(In reply to Sebastian Dröge (slomo) from comment #1) [...] > sthd is not used anywhere in your patch, should it? I'd added it in initially because the sthd (Subtitle Media Header) box was defined in an amendment to the ISO BMFF spec, but it turns out that the box doesn't carry any information. I'll remove it from the patch...
Created attachment 309472 [details] [review] Add support for XML timed-text subtitles Updated patch, as per comments.
Comment on attachment 309472 [details] [review] Add support for XML timed-text subtitles Looks good to me, thanks. Do you also have an element that actually handles these subtitles and can render them?
(In reply to Sebastian Dröge (slomo) from comment #4) > Comment on attachment 309472 [details] [review] [review] > Add support for XML timed-text subtitles > > Looks good to me, thanks. Do you also have an element that actually handles > these subtitles and can render them? Yes, I have an extended version of subparse that parses them, and a modified version of textoverlay that renders them. I'm currently getting the code ready to share - should hopefully be available soon.
commit 563ffc0d8ff426a6691051e289a6beec3e20abdf Author: Chris Bass <floobleflam@gmail.com> Date: Tue Aug 18 14:30:57 2015 +0100 qtdemux: support timed-text subtitle tracks. https://bugzilla.gnome.org/show_bug.cgi?id=752818