GNOME Bugzilla – Bug 752776
dashdemux: tests: extend unit tests
Last modified: 2015-08-16 13:37:55 UTC
Extend dashdemux unit tests for baseURL and duration formats
Created attachment 307986 [details] [review] patch 1/2 improvements in baseURL unit test
Created attachment 307987 [details] [review] patch 2/2 added duration format unit test
Review of attachment 307986 [details] [review]: This removes one test to add another, wouldn't it be better to verify both cases?
it improves the original test. The new test does everything the initial one did, but adds more checks (tests the inheritance of BaseURL and url construction)
It removes one of the possible use cases (only having baseurl) in favor of a more complex one. Wouldn't it be better to keep both or to add more possibilities to make the test more complete?
Added a few more tests for baseURL to cover the original use case and some others. This should do it. commit 9c291904f58d9cf5f7a84a2adf2abef79fe04c12 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Sat Aug 1 15:09:19 2015 -0300 tests: dash_mpd: add one more baseURL test This other type of baseURL test was replaced by a more complex one, better have both to keep both options working Also adds another 2 variations of how baseURL can be generated https://bugzilla.gnome.org/show_bug.cgi?id=752776 commit 6ce65709bda5ab6915ef7f080ea959b02d2f12f6 Author: Florin Apostol <florin.apostol@oregan.net> Date: Thu Jul 23 10:54:36 2015 +0100 dashdemux: tests: added duration format test https://bugzilla.gnome.org/show_bug.cgi?id=752776 commit 86c12c73571c91e64dc18057403cefe27770487d Author: Florin Apostol <florin.apostol@oregan.net> Date: Wed Jul 22 11:42:23 2015 +0100 dashdemux: tests: update unit test for baseURL Update the unit test for baseURL to test that it is properly resolved taking into account parent baseURL elements. https://bugzilla.gnome.org/show_bug.cgi?id=752776