After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752728 - Nonuniform prefixing of types with Gst:: namespace
Nonuniform prefixing of types with Gst:: namespace
Status: RESOLVED FIXED
Product: gstreamermm
Classification: Bindings
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamermm-maint
gstreamermm-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-22 14:47 UTC by Michał Wróbel
Modified: 2015-08-07 11:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Uniformly prefix types with Gst:: namespace (45.25 KB, patch)
2015-07-22 14:48 UTC, Michał Wróbel 		none Details | Review
Prefix TagList with Gst:: namespace (1.97 KB, patch)
2015-07-23 09:24 UTC, Michał Wróbel 		none Details | Review

Description Michał Wróbel 2015-07-22 14:47:09 UTC 
In contrary to C++ compiler, gmmproc doesn't look at type declarations and doesn't analyze the current namespace. Therefore despite having the code wrapped in a Gst namespace, gmmproc sees Class and Gst::Class as different types. This makes it easy for gstreamermm developer to make a mistake which causes gmmproc fail to find proper type conversions even though they seem to be defined. To avoid mistakes like this it is best to keep uniformity by explicitly using Gst:: namespace either everywhere or nowhere.
Comment 1 Michał Wróbel 2015-07-22 14:48:09 UTC 
Created attachment 307913 [details] [review]
Uniformly prefix types with Gst:: namespace
Comment 2 Marcin Kolny (IRC: loganek) 2015-07-23 07:20:58 UTC 
Thanks for your patch. Btw.I removed trailing whitespaces in your patch.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 3 Michał Wróbel 2015-07-23 08:57:50 UTC 
BTW my patch didn't introduce any whitespaces. It just didn't remove them :-).
Comment 4 Michał Wróbel 2015-07-23 09:23:15 UTC 
I missed (at least) one type: TagList inside discovererinfo.hg.
Comment 5 Michał Wróbel 2015-07-23 09:24:15 UTC 
Created attachment 307975 [details] [review]
Prefix TagList with Gst:: namespace
Comment 6 Marcin Kolny (IRC: loganek) 2015-08-07 11:00:26 UTC 
Thanks for patch. 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release.