Created attachment 307849 [details] [review]
lua-factory: Better debugging when registering sources

Created attachment 307850 [details] [review]
lua-factory: Add support for GRL_METADATA_KEY_SIZE

GRL_METADATA_KEY_SIZE is an int64 key, which we need to support.

Created attachment 307851 [details] [review]
lua-factory: Fix performer key containing only one name

Fix the handling of arrays of strings. We shouldn't always overwrite the
names previously there, especially as the key is emptied before handling
tables of values.

Created attachment 307852 [details] [review]
lua-factory: Add Pocket GResource file to the dist

Created attachment 307854 [details] [review]
lua-factory: Port Apple Trailers source to Lua

Created attachment 307855 [details] [review]
apple-trailers: Remove stand-alone C apple-trailers plugin

Review of attachment 307849 [details] [review]:

Sure.

Review of attachment 307850 [details] [review]:

Looks good otherwise

::: src/lua-factory/grl-lua-library.c
@@ +344,3 @@
+          grl_data_set_int64 (GRL_DATA (media), key_id, lua_tointeger (L, -1));
+        } else if (lua_istable (L, -1)) {
+          grl_util_add_table_to_media (L, media, key_id, key_name, type);

You will need to add G_TYPE_INT64 to grl_util_add_table_to_media as well

Review of attachment 307851 [details] [review]:

Sure.

::: src/lua-factory/grl-lua-library.c
@@ +206,3 @@
+    fixed = g_convert (str, -1, "UTF-8", "ISO8859-1", NULL, NULL, NULL);
+    if (fixed == NULL) {
+      g_warning ("Ignored non-UTF-8 and non-ISO8859-1 string for field '%s'", key_name);

GRL_WARNING?

Review of attachment 307852 [details] [review]:

Yes

Created attachment 307922 [details] [review]
lua-factory: Add support for GRL_METADATA_KEY_SIZE

GRL_METADATA_KEY_SIZE is an int64 key, which we need to support.

Created attachment 307923 [details] [review]
lua-factory: Fix performer key containing only one name

Fix the handling of arrays of strings. We shouldn't always overwrite the
names previously there, especially as the key is emptied before handling
tables of values.

Created attachment 307924 [details] [review]
lua-factory: Use GRL_WARNING instead of g_warning

Review of attachment 307924 [details] [review]:

yes

Review of attachment 307922 [details] [review]:

yes!

Review of attachment 307923 [details] [review]:

agreed

Review of attachment 307854 [details] [review]:

looks good as well!

Review of attachment 307855 [details] [review]:

I think it is necessary to port the apple-trailers test to the tests/lua-factory/sources as well.

Attachment 307849 [details] pushed as c101d06 - lua-factory: Better debugging when registering sources
Attachment 307852 [details] pushed as e8d8221 - lua-factory: Add Pocket GResource file to the dist
Attachment 307854 [details] pushed as 069f7dc - lua-factory: Port Apple Trailers source to Lua
Attachment 307922 [details] pushed as 46d7ebf - lua-factory: Add support for GRL_METADATA_KEY_SIZE
Attachment 307923 [details] pushed as d5e489d - lua-factory: Fix performer key containing only one name
Attachment 307924 [details] pushed as edb26e0 - lua-factory: Use GRL_WARNING instead of g_warning

All pushed to master, thanks for the reviews!