After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752662 - registry: Add plugins to the registry we are loading and not default one
registry: Add plugins to the registry we are loading and not default one
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-21 11:47 UTC by Thibault Saunier
Modified: 2015-08-16 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
registry: Add plugins to the registry we are loading and not default one (3.01 KB, patch)
2015-07-21 11:47 UTC, Thibault Saunier
committed Details | Review

Description Thibault Saunier 2015-07-21 11:47:16 UTC
When running gst_registry_scan_plugin_file we were losing the
information about the registry being loaded and ended up adding the
plugin to the default registry which was not correct.
Comment 1 Thibault Saunier 2015-07-21 11:47:21 UTC
Created attachment 307824 [details] [review]
registry: Add plugins to the registry we are loading and not default one
Comment 2 Tim-Philipp Müller 2015-07-21 11:55:04 UTC
How are you using a non-default registry?

The intention was to make the registry a singleton really, even if we clearly don't enforce that at the moment so you can still get around it using g_object_new() etc.
Comment 3 Thibault Saunier 2015-07-21 12:03:38 UTC
We have a dedicated registry for GstValidate plugins. The API makes clear that it is possible, and it works just fine. Though without that little patch we could not list_plugins from that dedicated registry.
Comment 4 Tim-Philipp Müller 2015-07-21 15:38:04 UTC
Comment on attachment 307824 [details] [review]
registry: Add plugins to the registry we are loading and not default one

Patch is obviously correct. Perhaps you could rename the func to _load_file_for_registry() or something, to make the difference/function clearer.
Comment 5 Nicolas Dufresne (ndufresne) 2015-08-05 21:34:29 UTC
Attachment 307824 [details] pushed as 749810b - registry: Add plugins to the registry we are loading and not default one
Comment 6 Nicolas Dufresne (ndufresne) 2015-08-05 21:37:37 UTC
I've renamed as suggested.