After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752638 - notebook tab dragging doesn't work on Quartz (patches included to fix for gtk2+3)
notebook tab dragging doesn't work on Quartz (patches included to fix for gtk...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Quartz
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-quartz maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-07-20 19:46 UTC by Paul Davis
Modified: 2015-07-26 06:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for GDK-quartz DnD (1.41 KB, patch)
2015-07-20 19:46 UTC, Paul Davis 		reviewed Details | Review
patch for GTK-quartz DnD (1.84 KB, patch)
2015-07-20 19:47 UTC, Paul Davis 		reviewed Details | Review

Description Paul Davis 2015-07-20 19:46:35 UTC 
Created attachment 307782 [details] [review]
patch for GDK-quartz DnD

DnD on Quartz fails to even attempt to check whether the drop target is a known GdkWindow. Because of this, the process never generates GTK_DRAG_RESULT_NO_TARGET which prevents GtkNotebook from ever executing the code at drag end which does tab tearoff.

The two simple attachments are patches that fix this problem. The patches were generated in GTK+2 code, but they will apply cleanly to GTK+3 also. If necessary, I will generate new versions of both patches for GTK+3.
Comment 1 Paul Davis 2015-07-20 19:47:16 UTC 
Created attachment 307783 [details] [review]
patch for GTK-quartz DnD
Comment 2 Matthias Clasen 2015-07-21 11:17:27 UTC 
Patches look good to me; if you could turn them into git-formatted patches with commit messages, that would be great.
Comment 3 Matthias Clasen 2015-07-23 05:33:21 UTC 
Review of attachment 307782 [details] [review]:

please add a commit message, and commit
Comment 4 Matthias Clasen 2015-07-23 05:33:42 UTC 
Review of attachment 307783 [details] [review]:

please add a commit message, then it is fine to commit.