After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752604 - gst-plugins-ugly compile error use Dockerfile: variable 'vsize' set but not used [-Werror=unused-but-set-variable]
gst-plugins-ugly compile error use Dockerfile: variable 'vsize' set but not u...
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
1.5.2
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-20 00:53 UTC by ZhangPing
Modified: 2015-07-21 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix compile errors (2.52 KB, patch)
2015-07-20 01:55 UTC, Vineeth
rejected Details | Review

Description ZhangPing 2015-07-20 00:53:42 UTC
Dockerfile as following:

FROM ubuntu:14.04.2

MAINTAINER Zhang Ping, dqzhangp@163.com
# install required packages
RUN apt-get update
RUN apt-get install -y git autoconf automake libtool pkg-config autopoint gettext liborc-0.4-dev make libglib2.0-dev flex bison
RUN git clone git://anongit.freedesktop.org/gstreamer/gstreamer && \
        cd gstreamer && \
        git checkout 1.5.2 && \
        ./autogen.sh --prefix=/usr --disable-gtk-doc-pdf --disable-gtk-doc --disable-gst-debug && \
        make && \
        make install
RUN apt-get install -y libpango1.0-dev
RUN git clone git://anongit.freedesktop.org/gstreamer/gst-plugins-base && \
        cd gst-plugins-base && \
        git checkout 1.5.2 && \
        ./autogen.sh --prefix=/usr --disable-gtk-doc-pdf --disable-gtk-doc --disable-gst-debug && \
        make && \
        make install
RUN git clone git://anongit.freedesktop.org/gstreamer/gst-plugins-good && \
        cd gst-plugins-good && \
        git checkout 1.5.2 && \
        ./autogen.sh --prefix=/usr --disable-gtk-doc-pdf --disable-gtk-doc --disable-gst-debug && \
        make && \
        make install
RUN apt-get install -y libmpeg2-4-dev libmad-ocaml-dev libmp3lame-dev liba52-0.7.4-dev libx264-dev
RUN git clone git://anongit.freedesktop.org/gstreamer/gst-plugins-ugly && \
        cd gst-plugins-ugly && \
        git checkout 1.5.2 && \
        ./autogen.sh --prefix=/usr --disable-gtk-doc-pdf --disable-gtk-doc && \
        make && \
        make install

docker build output:

make[3]: Entering directory `/gst-plugins-ugly/gst/asfdemux'
  CC       libgstasf_la-gstasfdemux.lo
gstasfdemux.c: In function 'gst_asf_demux_parse_stream_object':
gstasfdemux.c:2798:59: error: variable 'silence_data' set but not used [-Werror=unused-but-set-variable]
           guint span, packet_size, chunk_size, data_size, silence_data;
                                                           ^
gstasfdemux.c:2863:15: error: variable 'vsize' set but not used [-Werror=unused-but-set-variable]
       guint16 vsize;
               ^
gstasfdemux.c:2730:16: error: variable 'time_offset' set but not used [-Werror=unused-but-set-variable]
   GstClockTime time_offset;
                ^
gstasfdemux.c: In function 'gst_asf_demux_process_file':
gstasfdemux.c:3418:11: error: variable 'packets_count' set but not used [-Werror=unused-but-set-variable]
   guint64 packets_count, play_time, preroll;
           ^
gstasfdemux.c: In function 'gst_asf_demux_process_ext_stream_props':
gstasfdemux.c:3828:9: error: variable 'obj_size' set but not used [-Werror=unused-but-set-variable]
   guint obj_size;
         ^
gstasfdemux.c:3827:11: error: variable 'data_start' set but not used [-Werror=unused-but-set-variable]
   guint8 *data_start;
           ^
cc1: all warnings being treated as errors
make[3]: *** [libgstasf_la-gstasfdemux.lo] Error 1
make[3]: Leaving directory `/gst-plugins-ugly/gst/asfdemux'
make[2]: *** [asfdemux] Error 2
make[2]: Leaving directory `/gst-plugins-ugly/gst'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/gst-plugins-ugly'
make: *** [all] Error 2
2015/07/19 18:40:53 The command [/bin/sh -c git clone git://anongit.freedesktop.org/gstreamer/gst-plugins-ugly &&        cd gst-plugins-ugly &&        git checkout 1.5.2 &&        ./autogen.sh --prefix=/usr --disable-gtk-doc-pdf --disable-gtk-doc &&        make &&        make install] returned a non-zero code: 2
Comment 1 Vineeth 2015-07-20 01:55:39 UTC
Created attachment 307701 [details] [review]
fix compile errors

Can you check if this patch solves the compile error.
The variables are being set and used only in logging statements. Hence the error.
Comment 2 Tim-Philipp Müller 2015-07-21 10:36:50 UTC
> Dockerfile as following:
> 
> FROM ubuntu:14.04.2
> 
> MAINTAINER Zhang Ping, dqzhangp@163.com
> # install required packages
> RUN apt-get update
> RUN apt-get install -y git autoconf automake libtool pkg-config autopoint
> gettext liborc-0.4-dev make libglib2.0-dev flex bison
> RUN git clone git://anongit.freedesktop.org/gstreamer/gstreamer && \
>         cd gstreamer && \
>         git checkout 1.5.2 && \
>         ./autogen.sh --prefix=/usr --disable-gtk-doc-pdf --disable-gtk-doc
> --disable-gst-debug && \
>         make && \
>         make install

Thanks for the bug report, but if --disable-gst-debug is used, you should also use --disable-fatal-warnings.
Comment 3 Tim-Philipp Müller 2015-07-21 10:40:57 UTC
Note that this is only needed when building from git, not release tarballs.

If someone wants to make a patch that detects GST_DISABLE_GST_DEBUG was used in core and disables fatal_warnings in the modules then, that would be acceptable.