After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752595 - lua-factory: Add grl.is_video_site() function
lua-factory: Add grl.is_video_site() function
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: lua
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-19 16:48 UTC by Bastien Nocera
Modified: 2015-07-21 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lua-factory: Add grl.is_video_site() function (3.48 KB, patch)
2015-07-19 16:48 UTC, Bastien Nocera
none Details | Review
lua-factory: Add grl.is_video_site() function (3.48 KB, patch)
2015-07-20 12:12 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2015-07-19 16:48:25 UTC
.
Comment 1 Bastien Nocera 2015-07-19 16:48:29 UTC
Created attachment 307692 [details] [review]
lua-factory: Add grl.is_video_site() function

Based upon totem-pl-parser's totem_pl_parser_can_parse_from_uri()
function.
Comment 2 Victor Toso 2015-07-20 12:01:59 UTC
Review of attachment 307692 [details] [review]:

Looks good. I'll test it out this afternoon and push it.

::: src/lua-factory/grl-lua-library.c
@@ +1359,3 @@
+  ret = totem_pl_parser_can_parse_from_uri (url, FALSE);
+#else
+  grl_debug ("Return FALSE for whether '%s' is a video site, as compiled without totem-plparser-mini support", url);

GRL_DEBUG (..)
Comment 3 Bastien Nocera 2015-07-20 12:12:06 UTC
Created attachment 307758 [details] [review]
lua-factory: Add grl.is_video_site() function

Based upon totem-pl-parser's totem_pl_parser_can_parse_from_uri()
function.
Comment 4 Bastien Nocera 2015-07-20 12:23:36 UTC
Note that the patch might not apply cleanly without the GOA patch merged.
Comment 5 Bastien Nocera 2015-07-21 12:42:09 UTC
Attachment 307758 [details] pushed as b5c2560 - lua-factory: Add grl.is_video_site() function