After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752500 - [review] lr/vpn-compat: libnm-glib: add libnm compat defines to nm-vpn-plugin-ui-interface.h
[review] lr/vpn-compat: libnm-glib: add libnm compat defines to nm-vpn-plugin...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN (general)
git master
Other Linux
: Normal normal
: ---
Assigned To: Lubomir Rintel
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review 752471 752472 752489 752499
 
 
Reported: 2015-07-16 15:51 UTC by Lubomir Rintel
Modified: 2015-07-25 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lubomir Rintel 2015-07-16 15:51:42 UTC 
Add a bunch of compat defines to nm-vpn-plugin-ui-interface.h, to make
it easier to compile the same code against libnm-glib's
NMVpnPluginUiInterface and libnm's NMVpnEditorPlugin.
Comment 1 Thomas Haller 2015-07-16 15:59:06 UTC 
Looks good, but should see it in action.
Comment 2 Dan Williams 2015-07-23 21:17:56 UTC 
Looks OK to me too.
Comment 3 Lubomir Rintel 2015-07-25 08:52:17 UTC 
Finished porting the plugins to libnm and they all work fine with this, so I'm applying this:

72953e3 libnm-glib: add libnm compat defines to nm-vpn-plugin-ui-interface.h