GNOME Bugzilla – Bug 752493
harness: Improve detection of element type
Last modified: 2015-08-16 13:40:03 UTC
The attached patch improves how GstHarness will detect how to setup an element, particularly a bin.
Created attachment 307560 [details] [review] harness: Improve detection of element type The element flag does not indicate wether a bin should be tested as a source or as a sink, eg. a bin with the sink flag may still have a source pad and a bin with the source flag may have a sink pad. In this case it is better to determine the element type by looking at the available pads and pad templates. Also rename srcpad and sinkpad where it actually represents element_srcpad_name and element_sinkpad_name.
This didn't apply because of the header changes I made, but I fixed it up: commit 8597284d0be697bffbdb9f31a0f4e6576bc0a73f Author: Stian Selnes <stian@pexip.com> Date: Mon Jul 13 11:03:13 2015 +0200 harness: Improve detection of element type The element flag does not indicate wether a bin should be tested as a source or as a sink, eg. a bin with the sink flag may still have a source pad and a bin with the source flag may have a sink pad. In this case it is better to determine the element type by looking at the available pads and pad templates. Also rename srcpad and sinkpad where it actually represents element_srcpad_name and element_sinkpad_name. https://bugzilla.gnome.org/show_bug.cgi?id=752493 But please update/rebase before making more patches against the header :)