After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752419 - dashdemux: string is used to print a warning message after it was freed
dashdemux: string is used to print a warning message after it was freed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-15 12:40 UTC by Florin Apostol
Modified: 2015-08-16 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.95 KB, patch)
2015-07-15 12:42 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-07-15 12:40:18 UTC 
In several places in gstmpdparser.c file, the prop_string is freed before it is used in a warning message, eg:

  xmlFree (prop_string);
  GST_WARNING ("failed to parse property %s from xml string %s", property_name,
      prop_string);
Comment 1 Florin Apostol 2015-07-15 12:42:35 UTC 
Created attachment 307474 [details] [review]
proposed patch
Comment 2 Tim-Philipp Müller 2015-07-16 19:01:36 UTC 
Thanks, pushed:

commit 8b558d68cbacd354121e980aafc96c92574bc78c
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Wed Jul 15 13:41:37 2015 +0100

    dashdemux: free prop_string only after it's no longer needed
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752419