After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752138 - Magnifier issues
Magnifier issues
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: magnifier
3.16.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-08 20:11 UTC by RJ Murdok
Modified: 2015-07-27 16:19 UTC
See Also:
GNOME target: ---
GNOME version: 3.15/3.16


Attachments
magnifier: Avoid caret/focus viewport changes while the pointer moves (2.82 KB, patch)
2015-07-24 16:55 UTC, Rui Matos
none Details | Review
magnifier: Avoid caret/focus viewport changes while the pointer moves (3.71 KB, patch)
2015-07-27 14:03 UTC, Rui Matos
committed Details | Review

Description RJ Murdok 2015-07-08 20:11:19 UTC
The magnifier in Gnome-Shell has become impossible for me to use comfortably. in 3.14, an issue existed where icons in the overview would be cut off. Decided not to report this as I figured it would be fixed with 3.16. It wasn't. 3.16 started a larger issue. When magnifying menus, the cursor will jump, and this causes strain on my eyes. Since Gnome is meant to be universal and for everyone I have filed this as major. It needs to be fixed. I also noticed that when using a Wayland session the magnifier causes the session to crash.

Thanks for your time. I would be happy to help fix this.
Comment 1 André Klapper 2015-07-09 15:12:21 UTC
Thanks for reporting this.
Could you please provide a clear list of steps, to allow others to reproduce the problems that you're facing? Thanks in advance!
Comment 2 RJ Murdok 2015-07-09 18:18:19 UTC
(In reply to André Klapper from comment #1)
> Thanks for reporting this.
> Could you please provide a clear list of steps, to allow others to reproduce
> the problems that you're facing? Thanks in advance!

Hold super+alt+8 to enable the magnifier, then press alt+super+= at the same time. Then access the overview by pressing super and clicking on the icon with 9 dots on the dock found on the far left. From there you can see that icons off to the side are cut off. To view the bug with menus simply click on any element that uses a menu and move the cursor over it. You will notice that the cursor jerks thus moving the magnification view.
Comment 3 RJ Murdok 2015-07-23 21:35:14 UTC
So is this being worked on or has it been abandoned like every other person's report involving similar issues?

I've filed tons of bugs for KDE and developers started working on them immediately. It is unfortunate that a project I looked up to a couple years ago has become so isolated.

You guys make it hard to test development releases of Gnome, challenging for important bugs to be fixed, and a pain in the ass to modify Gnome in any way due to how reliant each component of Gnome is upon the other.

I'm sorry if I appear to be an ass who whines about everything, but that's the way I see it.

Advice for the future: if it works don't fix it (Gnome 2) because obviously the Gnome team is incompotent of aiding the disabled user base. 

I'm not sure what to tell my clients. They are torn about the broken implementation of your magnifier and the rough edges of KDE. I thought by now Gnome would make a viable argument as to why people should make the switch to Linux. Unfortunately I was wrong. 

When you make a release of Gnome make sure it is stable in nearly every aspect. Until then I recommend you regress the current 'stable' version of Gnome to whatever was considered to be the latest working release. Until then, keep 3.17 in development and don't release 3.18 with bugs. It saves headaches.
Comment 4 André Klapper 2015-07-24 16:10:43 UTC
(In reply to RJ Murdok from comment #3)
> So is this being worked on

There is no activity in this ticket, so probably not. 
Manpower is limited and based on volunteers in free software projects.

> You guys make it hard to test development releases of Gnome

That's something to potentially discuss on https://mail.gnome.org/mailman/listinfo/desktop-devel-list - curious why you consider it "hard".

> Advice for the future: if it works don't fix it (Gnome 2) because obviously
> the Gnome team is incompotent of aiding the disabled user base. 

Please see https://wiki.gnome.org/Foundation/CodeOfConduct before adding further comments. Nobody stops you from using a distribution based on GNOME 2. The accessibility stack has improved a lot since GNOME 2 (which does not mean that it has suddenly become bug-free). Please be welcome to discuss specific concerns on https://mail.gnome.org/mailman/listinfo/gnome-accessibility-list and feel free to get involved to get important issues fixed (or get a service level agreement with your distributor to fix important issues for you).
Comment 5 Rui Matos 2015-07-24 16:55:56 UTC
Created attachment 308092 [details] [review]
magnifier: Avoid caret/focus viewport changes while the pointer moves

If there's a caret or focus move we should delay it until the pointer
is stationary for little while so as to avoid jittery and spurious
viewport movements.

---

(In reply to RJ Murdok from comment #2)
> Hold super+alt+8 to enable the magnifier, then press alt+super+= at
> the same time. Then access the overview by pressing super and
> clicking on the icon with 9 dots on the dock found on the far
> left. From there you can see that icons off to the side are cut off.

I think this is a symptom of the more general bug 659523.

> To view the bug with menus simply click on any element that uses a
> menu and move the cursor over it. You will notice that the cursor
> jerks thus moving the magnification view.

The attached patch should take care of this.

(In reply to RJ Murdok from comment #3)
> So is this being worked on or has it been abandoned like every other
> person's report involving similar issues?

I'm sorry, which reports? Can you provide specific instances?

> Advice for the future: if it works don't fix it (Gnome 2) because
> obviously the Gnome team is incompotent of aiding the disabled user
> base.

I understand that you might be frustrated but insulting people isn't
going to help you get bugs fixed. Also, please try to remain
objective, this is technical bug tracker.
Comment 6 RJ Murdok 2015-07-24 17:15:36 UTC
Thank you a lot! I'll try applying the patch. I'm sorry for my frustration, but it's disspointing to see a bug that's been around for a while persist. Will this patch be merged with 3.17? I appreciate the work that goes into Gnome Shell, and that bug was really annoying.

@André Klapper Sorry for getting on your nerves. I'd just hate to see other features progress when a base function isn't properly working.
Comment 7 André Klapper 2015-07-24 17:46:57 UTC
RJ: You didn't get "on my nerves", really, and I understand your frustration. I was more trying to elaborate on more effective ways to get things going. :)
Comment 8 RJ Murdok 2015-07-25 23:16:30 UTC
@Rui Matos, can I expect this fix in Gnome 3.17.5 or will need to go through revision?
Comment 9 Florian Müllner 2015-07-26 07:58:28 UTC
(In reply to RJ Murdok from comment #8)
> @Rui Matos, can I expect this fix in Gnome 3.17.5 or will need to go through
> revision?

So you can confirm that the patch fixes your issue?
Comment 10 RJ Murdok 2015-07-26 14:33:56 UTC
(In reply to Florian Müllner from comment #9)
> (In reply to RJ Murdok from comment #8)
> > @Rui Matos, can I expect this fix in Gnome 3.17.5 or will need to go through
> > revision?
> 
> So you can confirm that the patch fixes your issue?

The patch works.
Comment 11 Florian Müllner 2015-07-26 16:10:07 UTC
Review of attachment 308092 [details] [review]:

::: js/ui/magnifier.js
@@ +1091,3 @@
     scrollContentsTo: function(x, y) {
+        if (this._pointerIdleMonitor.get_idletime() < POINTER_REST_TIME) {
+            this._clearScrollContentsTimer();

This is called for either branch, so could just move this before the if block

@@ +1092,3 @@
+        if (this._pointerIdleMonitor.get_idletime() < POINTER_REST_TIME) {
+            this._clearScrollContentsTimer();
+            this._scrollContentsTimerId = Mainloop.timeout_add(POINTER_REST_TIME, Lang.bind(this, function() {

Is delaying always the right thing to do, or do we need to differentiate between caret/focus tracking and calls to the shiftContentsTo() DBus method? I guess not, but then I have no idea what users of the DBus interface are out there and what they expect ...
Comment 12 Rui Matos 2015-07-27 14:03:43 UTC
Created attachment 308220 [details] [review]
magnifier: Avoid caret/focus viewport changes while the pointer moves

--
(In reply to Florian Müllner from comment #11)
> Is delaying always the right thing to do, or do we need to
> differentiate between caret/focus tracking and calls to the
> shiftContentsTo() DBus method?  I guess not, but then I have no idea
> what users of the DBus interface are out there and what they expect

Good point, I missed that case. I think it's better to keep the
previous behavior for those callers, here's the revised patch.
Comment 13 Florian Müllner 2015-07-27 15:52:55 UTC
Review of attachment 308220 [details] [review]:

LGTM
Comment 14 Rui Matos 2015-07-27 16:19:32 UTC
For the other issue please follow bug 659523.

Attachment 308220 [details] pushed as f5865e8 - magnifier: Avoid caret/focus viewport changes while the pointer moves