GNOME Bugzilla – Bug 752132
hls/m3u8: Update current position in all cases
Last modified: 2015-10-20 07:13:18 UTC
The current position wasn't consistently updated based on what was previously outputted
Created attachment 307083 [details] [review] hls/m3u8: Update current position in all cases In order to ensure the sequence_position will always be consistently updated, store the current file duration. This way, when we advance, we can always increment the position based on what was previously outputted.
Created attachment 307334 [details] [review] hls/m3u8: Update current position in all cases In order to ensure the sequence_position will always be consistently updated, store the current file duration. This way, when we advance, we can always increment the position based on what was previously outputted.
There was an issue in the first patch. There was the possibility of a NULL dereference if client->current_file was NULL
Comment on attachment 307334 [details] [review] hls/m3u8: Update current position in all cases Makes sense
commit f7c4bb5ac63d03fc3131c86ed438b6f6d6992bcb Author: Edward Hervey <edward@centricular.com> Date: Wed Jul 8 17:17:12 2015 +0200 hls/m3u8: Update current position in all cases In order to ensure the sequence_position will always be consistently updated, store the current file duration. This way, when we advance, we can always increment the position based on what was previously outputted. https://bugzilla.gnome.org/show_bug.cgi?id=752132