After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752111 - rtpbasedepayload: Fix minor leak of segment event
rtpbasedepayload: Fix minor leak of segment event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.5.2
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-08 10:13 UTC by Stian Selnes (stianse)
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.23 KB, patch)
2015-07-08 10:13 UTC, Stian Selnes (stianse) 		reviewed Details | Review

Description Stian Selnes (stianse) 2015-07-08 10:13:19 UTC 
Created attachment 307060 [details] [review]
Patch

Attached patch fixes leak of segment event in the case where no buffers are
successfully depayloaded and pushed. Found while writings tests for rtph263depay which will be submitted soon.
Comment 1 Tim-Philipp Müller 2015-07-08 10:22:23 UTC 
I think this was fixed already:

commit fbf2773b2ea795a17a29e163a00f4b8d0a668b5e
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue Jul 7 15:05:59 2015 +0100

    rtpbasepayload: fix possible segment event leak
    
    Need to clear it when shutting down, not when starting up.
    Fixes leak in rtp-payloading unit test.
Comment 2 Tim-Philipp Müller 2015-07-08 10:23:20 UTC 
Oh nevermind, *de*payload :)
Comment 3 Tim-Philipp Müller 2015-07-08 10:33:20 UTC 
Actually, that was the same fix, I just messed up the commit message.