After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751926 - 2.43.3 build error: GISCAN GModule-2.0.gir Caught exception: <type 'exceptions.IOError'> IOError(2, 'No such file or directory')
2.43.3 build error: GISCAN GModule-2.0.gir Caught exception: <type 'excepti...
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
2.43.x
Other Linux
: Normal major
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-07-03 20:45 UTC by Olav Vitters
Modified: 2015-08-21 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scanner: fix cachestore race (1.80 KB, patch)
2015-07-03 22:45 UTC, Dieter Verfaillie
none Details | Review
Same thing as before but uses os.fdopen() as a context (1.72 KB, patch)
2015-07-05 09:02 UTC, Dieter Verfaillie
committed Details | Review
scanner: use open() as os.fdopen as context managers (10.91 KB, patch)
2015-07-05 09:03 UTC, Dieter Verfaillie
committed Details | Review

Description Olav Vitters 2015-07-03 20:45:27 UTC
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20150703203611.ovitters.valstar.25423/log/gobject-introspection-1.45.3-1.mga6/build.0.20150703203703.log

g-ir-scanner: GLib: warning: 710 warnings suppressed (use --warn-all to see them)
make[2]: Leaving directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
make[2]: Entering directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
  GISCAN   GModule-2.0.gir
Caught exception: <type 'exceptions.IOError'> IOError(2, 'No such file or directory')
> /usr/lib64/python2.7/shutil.py(82)copyfile()
-> with open(src, 'rb') as fsrc:
(Pdb) 
Makefile:3462: recipe for target 'GModule-2.0.gir' failed
make[2]: *** [GModule-2.0.gir] Error 1
make[2]: Leaving directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
make[2]: *** Waiting for unfinished jobs....
make[2]: Entering directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
  GICOMP   GLib-2.0.gir
make[2]: Leaving directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
make[2]: Entering directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
  GISCAN   GObject-2.0.gir
/usr/include/glib-2.0/gobject/gobject-autocleanups.h:25: syntax error, unexpected typedef-name, expecting identifier or '(' in 'typedef GObject *GObject_autoptr;' at 'GObject_autoptr'
/usr/include/glib-2.0/gobject/gobject-autocleanups.h:26: syntax error, unexpected typedef-name, expecting identifier or '(' in 'typedef GInitiallyUnowned *GInitiallyUnowned_autoptr;' at 'GInitiallyUnowned_autoptr'
g-ir-scanner: GObject: warning: 20 warnings suppressed (use --warn-all to see them)
make[2]: Leaving directory '/home/iurt/rpmbuild/BUILD/gobject-introspection-1.45.3'
Makefile:2753: recipe for target 'all-recursive' failed

I'm on IRC atm, ovitters @ #gnome-shell channel.
Comment 1 Olav Vitters 2015-07-03 21:19:39 UTC
Builds fine on my own machine. Guessing the high cpu/ make -j is causing this? Lowering priority.
Comment 2 Dieter Verfaillie 2015-07-03 22:45:03 UTC
Created attachment 306785 [details] [review]
scanner: fix cachestore race

Using tempfile.mkstemp should prevent the temp file
from being cleaned while it might still be used by
another process.
Comment 3 Olav Vitters 2015-07-04 13:39:14 UTC
Comment on attachment 306785 [details] [review]
scanner: fix cachestore race

Tested this on the build system. Patch works!
Comment 4 Dieter Verfaillie 2015-07-05 09:02:58 UTC
Created attachment 306843 [details] [review]
Same thing as before but uses os.fdopen() as a context

manager instead of closing the file manually.

scanner: fix cachestore race

Using tempfile.mkstemp should prevent the temp file
from being cleaned while it might still be used by
another process.
Comment 5 Dieter Verfaillie 2015-07-05 09:03:10 UTC
Created attachment 306844 [details] [review]
scanner: use open() as os.fdopen as context managers

Ensures files are correctly and immediately closed.
Comment 6 Emmanuele Bassi (:ebassi) 2015-08-21 11:58:06 UTC
Review of attachment 306843 [details] [review]:

Looks good.
Comment 7 Emmanuele Bassi (:ebassi) 2015-08-21 12:00:29 UTC
Review of attachment 306844 [details] [review]:

I do like context managers for RAII-like behaviour, so this looks like a good improvement to me.
Comment 8 Emmanuele Bassi (:ebassi) 2015-08-21 12:11:03 UTC
Attachment 306844 [details] pushed as 23e5dd8 - scanner: fix cachestore race
Attachment 306844 [details] pushed as ebe6585 - scanner: use open() as os.fdopen as context managers