GNOME Bugzilla – Bug 751559
qtmux: Implement the preset interface.
Last modified: 2016-09-30 07:03:20 UTC
+ And provide a "youtube" preset, which based on https://support.google.com/youtube/answer/1722171 sets faststart to True.
Created attachment 306180 [details] [review] qtmux: Implement the preset interface.
Review of attachment 306180 [details] [review]: ::: gst/isomp4/GstQTMux.prs @@ +1,2 @@ +[_presets_] +version=0.10 Is that normal ?
copy paste from vp8enc, not sure what this does actually(In reply to Nicolas Dufresne (stormer) from comment #2) > Is that normal ? copy paste from vp8enc, not sure what this does actually(In reply to Nicolas
Maybe it's a left over in the 0.10 porting ? Better check what this version is supposed to be.
Created attachment 334580 [details] [review] qtmux: Implement the preset interface. + And provide a "youtube" preset, which based on https://support.google.com/youtube/answer/1722171 sets faststart to True.
I gave a look at gstpreset.c, apparently this is used for checking that a preset applies at least to the version of gstreamer that is used. A preset like GstFreeverb.prs (randomly picked) was added in 2014 and tagged with version=1.5.0.1, I assume that was the current version at the time. As I can't guarantee the preset doesn't rely on properties that were added before I wrote the patch, I'd tag it with the first version following the patch date, 1.6.0. The updated patch does just that :)
Comment on attachment 334580 [details] [review] qtmux: Implement the preset interface. Go ahead after 1.9.2 is out
Attachment 334580 [details] pushed as 26928b3 - qtmux: Implement the preset interface.