After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751500 - dashdemux: incorrect use of timeShiftBufferDepth
dashdemux: incorrect use of timeShiftBufferDepth
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-25 14:00 UTC by Florin Apostol
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.13 KB, patch)
2015-06-25 14:06 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-06-25 14:00:02 UTC 
If not set, the timeShiftBufferDepth has a default value of -1. The standard says that this should be interpreted as infinite.

The gst_mpd_client_check_time_position function incorrectly compares timeShiftBufferDepth with 0 instead of -1 to determine if it was set.
Comment 1 Florin Apostol 2015-06-25 14:06:04 UTC 
Created attachment 306108 [details] [review]
proposed patch
Comment 2 Sebastian Dröge (slomo) 2015-06-25 14:27:39 UTC 
commit fa9b03186ac8999b3b5632cd567f18b497df22d2
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Jun 25 15:05:20 2015 +0100

    dash: Correct check for valid timeShiftBufferDepth
    
    If not set, the timeShiftBufferDepth has a default value of -1.
    The standard says that this should be interpreted as infinite.
    
    The gst_mpd_client_check_time_position function incorrectly compares
    timeShiftBufferDepth with 0 instead of -1 to determine if it was set.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751500