After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751465 - dashdemux: incorrect use of period start
dashdemux: incorrect use of period start
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-24 20:49 UTC by Florin Apostol
Modified: 2015-08-16 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.42 KB, patch)
2015-06-24 20:50 UTC, Florin Apostol
committed Details | Review

Description Florin Apostol 2015-06-24 20:49:50 UTC
The period start information, calculated in gst_mpd_client_setup_media_presentation function is stored in 
stream_period->start. The information read from xml file and stored in stream_period->period->start is not changed.
    
If the xml file does not contain the period start information,
stream_period->period->start will be -1.
    
The function gst_mpd_client_get_next_segment_availability_end_time wants to use period start time, but incorrectly uses stream_period->period->start (value from xml file, which could be -1) instead of stream_period->start (computed value)
Comment 1 Florin Apostol 2015-06-24 20:50:24 UTC
Created attachment 306053 [details] [review]
proposed patch
Comment 2 Sebastian Dröge (slomo) 2015-06-25 08:14:58 UTC
commit 93f08347de7b725f568b74e972c7d4a59773bb6f
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Wed Jun 24 21:42:32 2015 +0100

    dashdemux: incorrect use of period start
    
    The period start information, calculated in gst_mpd_client_setup_media_presentation
    function is stored in stream_period->start. The information read from
    xml file and stored in stream_period->period->start is not changed.
    
    If the xml file does not contain the period start information,
    stream_period->period->start will be -1.
    
    The function gst_mpd_client_get_next_segment_availability_end_time wants to
    use period start time, but incorrectly uses stream_period->period->start
    (value from xml file, which could be -1) instead of stream_period->start
    (computed value)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751465