After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751415 - Remove button is always insensitive
Remove button is always insensitive
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-23 22:59 UTC by Michael Catanzaro
Modified: 2015-06-24 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GbGreeterWindow: fix notify in selection mode (1.39 KB, patch)
2015-06-24 14:42 UTC, sébastien lafargue 		committed Details | Review

Description Michael Catanzaro 2015-06-23 22:59:55 UTC 
The Remove button in the bottom-left of the project overview, for removing projects from the list of projects, no longer works: it can never be clicked.
Comment 1 sébastien lafargue 2015-06-24 12:25:24 UTC 
If you check the mark, it is insensitive but it's working when clicking the row itself.
Comment 2 sébastien lafargue 2015-06-24 14:42:40 UTC 
Created attachment 306009 [details] [review]
GbGreeterWindow: fix notify in selection mode

WHenm in selection mode, you click a row checkbox,
the remove button at the button don't change its state.
Comment 3 sébastien lafargue 2015-06-24 14:52:46 UTC 
With this solution, there's a short notify cycle, that is :

checkbox -> selected -> checkbox instead of checkbox ->selected

and

selected -> checkbox -> selected  instead of selected -> checkbox

Christian, what do you think of ?
Comment 4 Christian Hergert 2015-06-24 19:05:52 UTC 
Review of attachment 306009 [details] [review]:

LGTM, feel free to push.
Comment 5 sébastien lafargue 2015-06-24 19:36:41 UTC 
Attachment 306009 [details] pushed as a8e101c - GbGreeterWindow: fix notify in selection mode