After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751393 - aacparse: LOAS config never retrieved
aacparse: LOAS config never retrieved
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.5.1
Other Linux
: Normal normal
: 1.6.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-23 16:02 UTC by Guillaume Marquebielle
Modified: 2015-09-25 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the issue (1.47 KB, patch)
2015-06-23 16:02 UTC, Guillaume Marquebielle
none Details | Review
AAC sample file gdppayed (932.37 KB, application/octet-stream)
2015-06-23 16:14 UTC, Guillaume Marquebielle
  Details

Description Guillaume Marquebielle 2015-06-23 16:02:08 UTC
Created attachment 305929 [details] [review]
Patch fixing the issue

I'm using aacparse on some live TV stream decoding pipeline.
I encountered some AAC sample for which the LOAS configuration is never retrieved.


For each LOAS frame, "use previous config" bit is set, the whole frame size is skipped and we never have any configuration.
It's not correct for the detect stream function to return TRUE if no previous config is found.
Indeed, returning FALSE on detect stream function when no previous config has been retrieved fixed this issue, as the handle frame function returned with skip_size = 1. And parsing from next byte leads to retrieving some valid configuration some steps further.

This should be cause by starting parsing from any position in frame.

I provided a patch to fix this and some AAC sample file to reproduce it.
Comment 1 Guillaume Marquebielle 2015-06-23 16:14:22 UTC
Created attachment 305933 [details]
AAC sample file gdppayed
Comment 2 Guillaume Marquebielle 2015-09-25 07:54:12 UTC
This issue has been resolved by last patch submitted on bug :

https://bugzilla.gnome.org/show_bug.cgi?id=751386
Comment 3 Tim-Philipp Müller 2015-09-25 08:04:06 UTC
Thanks for testing and letting us know.