After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751389 - CD-TEXT data charset misinterpreted (since libcdio 0.84)
CD-TEXT data charset misinterpreted (since libcdio 0.84)
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: cdda backend
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-06-23 15:48 UTC by Jonas Kümmerlin
Modified: 2015-06-23 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot showing misinterpreted text (77.39 KB, image/png)
2015-06-23 15:48 UTC, Jonas Kümmerlin 		  Details
Patch fixing the problem (1.53 KB, patch)
2015-06-23 15:49 UTC, Jonas Kümmerlin 		none Details | Review
Fix (2.25 KB, patch)
2015-06-23 16:05 UTC, Jonas Kümmerlin 		none Details | Review
Fixing it, 3rd attempt (2.73 KB, patch)
2015-06-23 19:37 UTC, Jonas Kümmerlin 		committed Details | Review

Description Jonas Kümmerlin 2015-06-23 15:48:37 UTC 
Created attachment 305927 [details]
Screenshot showing misinterpreted text

Starting with libcdio 0.84, cdtext_get_const() returns UTF-8, but gvfs interprets it as ISO-8859-1.

A screenshot demonstrating the problem and a patch is attached.
Comment 1 Jonas Kümmerlin 2015-06-23 15:49:09 UTC 
Created attachment 305928 [details] [review]
Patch fixing the problem
Comment 2 Jonas Kümmerlin 2015-06-23 16:05:11 UTC 
Created attachment 305932 [details] [review]
Fix

I messed up the previous one, this should be it.
Comment 3 Ross Lagerwall 2015-06-23 16:24:19 UTC 
Review of attachment 305932 [details] [review]:

Looks OK, but can you make cdtext_string_to_utf8 conditionally compiled only if LIBCDIO_VERSION_NUM < 84?
Comment 4 Jonas Kümmerlin 2015-06-23 19:37:25 UTC 
Created attachment 305955 [details] [review]
Fixing it, 3rd attempt
Comment 5 Ross Lagerwall 2015-06-23 22:57:37 UTC 
Pushed to master as acbe277ed3636668faaf343ba6353fb28dbc9ec0 and gnome-3-16 as 6bfecb830c98f7398a748c311fc97e986f97c668. Thanks!