After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751387 - aacparse: wrong src caps sample rate from LOAS frame
aacparse: wrong src caps sample rate from LOAS frame
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.5.1
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-23 15:39 UTC by Guillaume Marquebielle
Modified: 2018-11-03 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the issue (1.21 KB, patch)
2015-06-23 15:39 UTC, Guillaume Marquebielle
none Details | Review
AAC sample file gdppayed (492.27 KB, application/octet-stream)
2015-06-23 15:40 UTC, Guillaume Marquebielle
  Details

Description Guillaume Marquebielle 2015-06-23 15:39:25 UTC
Created attachment 305925 [details] [review]
Patch fixing the issue

This issue is related to bug :

https://bugzilla.gnome.org/show_bug.cgi?id=751386

and cannot be reproduced with the AAC sample file without previous bug fixed.

I'm testing with some AAC file extracted from live TV stream.
Parsing a LOAS frame with a valid configuration, the sample rate is at first set to 24000. Then, as the SBR flag is set, the sample rate is doubled and set to 48000.

This leads to wrong src caps for the element. Indeed, all AAC decoders make a difference between these 2 values as "sample_rate" and "extended_sample_rate".
But it's not correct in aacparse element to overwrite the first one by the second one and setting src caps with the extended sample rate.

Playing this aac sample file with typical pipeline including an audiorate element leads to stuttered audio.

The parser behavior should be the same for any transport type (ADTS, LOAS, ...).
As an example, VLC detects a 24000 sample rate with this file.

I provided a patch to fix this.
This issue is related to some discussion in :

https://bugzilla.gnome.org/show_bug.cgi?id=665394

Thx
Comment 1 Guillaume Marquebielle 2015-06-23 15:40:04 UTC
Created attachment 305926 [details]
AAC sample file gdppayed
Comment 2 GStreamer system administrator 2018-11-03 15:01:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/195.