After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751344 - Reinstate left/right window motion to window menu
Reinstate left/right window motion to window menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: window-management
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-06-22 20:14 UTC by Ron Yorston
Modified: 2015-06-23 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reinstate left/right window movement to window menu (1.82 KB, patch)
2015-06-22 20:14 UTC, Ron Yorston 		none Details | Review
Patch as created by git-format-patch (2.18 KB, patch)
2015-06-22 21:21 UTC, Ron Yorston 		committed Details | Review

Description Ron Yorston 2015-06-22 20:14:53 UTC 
Created attachment 305858 [details] [review]
Reinstate left/right window movement to window menu

Under bug #726352 the window menu was implemented in GNOME Shell.  The new implementation lost the menu items that allow windows to be moved to the workspaces left or right of the current workspace.

While this is fine for the vertical layout used by default in the Shell it's inconvenient for extensions that provide different layouts.  Rather than have such extensions replace the window menu wholesale it would be convenient if the
menu in the Shell supported left/right motion.  Of course, these wouldn't appear if the layout was vertical.
Comment 1 Florian Müllner 2015-06-22 20:57:29 UTC 
Review of attachment 305858 [details] [review]:

Could you include a commit message and re-create the patch with git-format-patch? Code looks good, thanks!
Comment 2 Ron Yorston 2015-06-22 21:21:16 UTC 
Created attachment 305874 [details] [review]
Patch as created by git-format-patch
Comment 3 Florian Müllner 2015-06-22 21:28:02 UTC 
Review of attachment 305874 [details] [review]:

Looks good, thanks!
Comment 4 Jasper St. Pierre (not reading bugmail) 2015-06-23 00:58:13 UTC 
Pushed, thanks.