Bug 751209 – Crash when new GOA account is added

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 751209 - Crash when new GOA account is added


Summary:	Crash when new GOA account is added


Status:	RESOLVED FIXED

Product:	gnome-calendar
Classification:	Applications
Component:	General
Version:	3.16.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	3.26
Assigned To:	GNOME Calendar maintainers
QA Contact:	GNOME Calendar maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-06-19 10:29 UTC by Milan Crha
Modified:	2017-04-17 18:20 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
proposed patch (735 bytes, patch) 2015-06-19 10:30 UTC, Milan Crha	none	Details \| Review

Description Milan Crha 2015-06-19 10:29:39 UTC

I've got this crash when the new GOA ownCloud account was added with the gnome-calendar being running.

The issue is simple, there were wrong data passed into the callback.

(gnome-calendar:32297): GLib-GObject-WARNING **: invalid cast from 'GcalManager' to 'GcalSourceDialog'

+ Trace 235188

Thread 1 (Thread 0x7f53c04fe9c0 (LWP 32297))

#0 waitpid
#1 g_spawn_sync
#2 g_spawn_command_line_sync
#3 run_bug_buddy
at gnome-segvhanlder.c line 245
#4 bugbuddy_segv_handle
at gnome-segvhanlder.c line 196
#5 <signal handler called>
#6 add_goa_account
at gcal-source-dialog.c line 2031
#7 goa_account_added_cb
at gcal-source-dialog.c line 2060
#8 g_cclosure_marshal_VOID__OBJECTv
#9 _g_closure_invoke_va
#10 g_signal_emit_valist
#11 g_signal_emit
#12 g_closure_invoke
#13 signal_emit_unlocked_R
#14 g_signal_emit_valist
#15 g_signal_emit_by_name
#16 add_interfaces
#17 on_control_proxy_g_signal
#18 ffi_call_unix64
#19 ffi_call
#20 g_cclosure_marshal_generic
#21 g_closure_invoke
#22 signal_emit_unlocked_R
#23 g_signal_emit_valist
#24 g_signal_emit
#25 on_signal_received
#26 emit_signal_instance_in_idle_cb
#27 g_main_context_dispatch
#28 g_main_context_iterate.isra
#29 g_main_context_iteration
#30 g_application_run
#31 main
at main.c line 43

Comment 1 Milan Crha 2015-06-19 10:30:22 UTC

Created attachment 305675 [details] [review]
proposed patch

Correct data for the callback.

Comment 2 Georges Basile Stavracas Neto 2015-06-21 01:59:17 UTC

Fixed. Commit afdd726d.