After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751129 - Fullscreen Wacom calibration window has decorations
Fullscreen Wacom calibration window has decorations
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
git master
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-17 21:34 UTC by Jason Gerecke
Modified: 2015-07-01 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: Fix signature of 'window-state-event' handler for calibrator (1.70 KB, patch)
2015-06-17 21:36 UTC, Jason Gerecke 		committed Details | Review

Description Jason Gerecke 2015-06-17 21:34:48 UTC 
The full-screen window which appears when calibrating a Wacom display does not hide its window decorations. This shifts the window origin away from the screen origin and causes incorrect calibration results.
Comment 1 Jason Gerecke 2015-06-17 21:36:55 UTC 
Created attachment 305504 [details] [review]
wacom: Fix signature of 'window-state-event' handler for calibrator

The 'on_fullscreen' function which handles the 'window-state-event'
signal should be returning a gboolean value. We fix the function
signature and have it return FALSE to allow the event to continue to
propogate.
Comment 2 Rui Matos 2015-06-29 16:11:51 UTC 
Review of attachment 305504 [details] [review]:

looks good
Comment 3 Bastien Nocera 2015-07-01 09:45:25 UTC 
Committed after some changes to the commit message. The subject should be
the user-visible changes brought by the commit. In this case, it's about
hiding the window decorations from the dialogue, which isn't mentioned
anywhere in the commit message!