After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751118 - playbin: current-suburi does not return correct status when an invalid SUBURI is passed
playbin: current-suburi does not return correct status when an invalid SUBURI...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.5.1
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-17 15:50 UTC by Brijesh Singh
Modified: 2015-06-22 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
free group->suburi on failure (947 bytes, patch)
2015-06-17 15:51 UTC, Brijesh Singh 		committed Details | Review

Description Brijesh Singh 2015-06-17 15:50:08 UTC 
While developing unit test for gst-player, I encountered the following issue. unit test executes the below sequence

- set uri
- set invalid suburi
- starts the pipeline
- after 4s, queries the suburi using g_object_get (playbin, "current-suburi", &val)
the current suburi return the previously set invalid suburi.

I do notice that warning_cb does report message from GstFileSrc that we are failed to find the resource but it would be nice if current-suburi property also provide updated status of current suburi being played.
Comment 1 Brijesh Singh 2015-06-17 15:51:33 UTC 
Created attachment 305489 [details] [review]
free group->suburi on failure
Comment 2 Sebastian Dröge (slomo) 2015-06-22 12:51:54 UTC 
commit ab79e5051041863c33230d238371923f68d1ea70
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 22 14:51:07 2015 +0200

    playbin: Reset suburi also when receiving an error message from the sub uridecodebin
    
    http://bugzilla.gnome.org/show_bug.cgi?id=751118

commit bcc9021071e8a1b683616710affca7887ab7f9d4
Author: Brijesh Singh <brijesh.ksingh@gmail.com>
Date:   Wed Jun 17 10:20:54 2015 -0500

    playbin: free group->suburi on failure
    
    If suburidecodebin is failed to negotiate (e.g file does not exist)
    then free internal suburi variable so that 'current-suburi' property
    returns correct status.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751118