After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751112 - Since gtk3 line number column isn't greyed in mousepad and gedit
Since gtk3 line number column isn't greyed in mousepad and gedit
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-17 14:35 UTC by Yan Pashkovsky
Modified: 2015-06-18 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Greybird Mousepad 0.4 (31.96 KB, image/png)
2015-06-17 15:10 UTC, Yan Pashkovsky
Details

Description Yan Pashkovsky 2015-06-17 14:35:08 UTC
Don't know which component is exactly guilty, but since GTK3 there is theme change in GtkSourceView, so line number column is the same color as a text field, it's confusing. In gtk2 it was gray.
Look here too https://bugzilla.xfce.org/show_bug.cgi?id=11990
Comment 1 Emmanuele Bassi (:ebassi) 2015-06-17 14:58:50 UTC
Re-assigning to the right component, but it would be helpful to know:

 - the version of GTK+ 3
 - the version of GtkSourceView
 - the theme you are using

before anybody is able to give you a meaningful answer.
Comment 2 Emmanuele Bassi (:ebassi) 2015-06-17 15:00:36 UTC
Also: a screenshot would help diagnose the issue for those not experiencing it.
Comment 3 Yan Pashkovsky 2015-06-17 15:10:03 UTC
Created attachment 305487 [details]
Greybird Mousepad 0.4

Themes where bug appeared: Greybird, Numix, Highcontrast
libgtk-3-dev Version: 3.14.13-0ubuntu1
libgtksourceview Version: 3.14.4-1
Comment 4 Matthew Brush 2015-06-17 23:11:38 UTC
I think the bug occurs in any theme that doesn't explicitly set a "line-numbers" style (which also sets "text" style, so both seem to need to be changed). I can get a normal background in the line numbers margin if I copy those two styles from the Kate theme.

I guess probably the default values broke/changed. Quickly skimming the Git log, it might be one of these:

https://git.gnome.org/browse/gtksourceview/commit/gtksourceview/gtksourcestyle.c?id=9ba6e86db7aa1d985580d7edf4f86528cb8aff10

https://git.gnome.org/browse/gtksourceview/commit/gtksourceview/gtksourcestylescheme.c?id=3f7b4fdfcd601b91194fd056a836d2b7d097eb47

But I could be way off base, I didn't investigate deeply.
Comment 5 Sébastien Wilmet 2015-06-18 12:53:38 UTC
With GtkSourceView 3.16 the line numbers column is gray, also with the classic and tango style schemes.
Comment 6 Yan Pashkovsky 2015-06-18 12:58:57 UTC
In classic and tango theme they were grey even in 3.14. Check please with one of listed above: Greybird, Numix, Highcontrast