After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751098 - wayland: Always request transient commit when mapping subsurface
wayland: Always request transient commit when mapping subsurface
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-06-17 09:41 UTC by Jonas Ådahl
Modified: 2015-06-17 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Always request transient commit when mapping subsurface (1.71 KB, patch)
2015-06-17 09:41 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-06-17 09:41:29 UTC 
This fixes auto complete window placement issues in evolution, and probably other window placement issuse I'm unaware of where subsurfaces are used.
Comment 1 Jonas Ådahl 2015-06-17 09:41:35 UTC 
Created attachment 305463 [details] [review]
wayland: Always request transient commit when mapping subsurface

A subsurface positioning operation only takes effect when the parent
surfaces state is applied. If a subsurface is mapped and positioned, but
the parent surface state is not immediately committed, the relative
position of the subsurface is undefined and may be placed incorrectly.

To avoid this undefined state, always request that the parent surface
should be committed after mapping a subsurface so that the position
operation will take effect.
Comment 2 Carlos Garnacho 2015-06-17 11:29:55 UTC 
Review of attachment 305463 [details] [review]:

Looks good!


FWIW, subsurfaces are currently only used by popovers, text handles, tooltips and the entry completion window
Comment 3 Jonas Ådahl 2015-06-17 12:48:26 UTC 
Attachment 305463 [details] pushed as 0dab37c - wayland: Always request transient commit when mapping subsurface