Bug 751062 – Panel crashes when trying to disable expanding

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 751062 - Panel crashes when trying to disable expanding


Summary:	Panel crashes when trying to disable expanding


Status:	RESOLVED FIXED

Product:	gnome-panel
Classification:	Other
Component:	panel
Version:	3.16.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Panel Maintainers
QA Contact:	Panel Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-06-16 17:04 UTC by Dmitry Shachnev
Modified:	2015-06-20 17:15 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
panel-widget: update size hints in panel_widget_set_packed (798 bytes, patch) 2015-06-19 21:36 UTC, Alberts Muktupāvels	committed	Details \| Review

Description Dmitry Shachnev 2015-06-16 17:04:23 UTC

When I go to panel properties for expanded panel, uncheck Expanded checkbox, I get the following crash:

+ Trace 235178

#0 panel_widget_size_allocate
at panel-widget.c line 1411
#1 g_cclosure_marshal_VOID__BOXED
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gmarshal.c line 1910
#2 g_type_class_meta_marshal
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 961
#6 <emit signal ??? on instance 0x82232c0 [PanelWidget]>
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3361
#7 gtk_widget_size_allocate_with_baseline
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6093
#8 gtk_widget_size_allocate
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6162
#9 panel_frame_size_allocate
at panel-frame.c line 157
#10 g_cclosure_marshal_VOID__BOXEDv
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gmarshal.c line 1950
#11 g_type_class_meta_marshalv
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 988
#12 _g_closure_invoke_va
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 831
#13 g_signal_emit_valist
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3214
#14 g_signal_emit
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3361
#15 gtk_widget_size_allocate_with_baseline
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6093
#16 gtk_grid_size_allocate
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkgrid.c line 1635
#17 gtk_grid_size_allocate
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkgrid.c line 1683
#18 g_cclosure_marshal_VOID__BOXEDv
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gmarshal.c line 1950
#19 g_type_class_meta_marshalv
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 988
#20 _g_closure_invoke_va
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 831
#21 g_signal_emit_valist
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3214
#22 g_signal_emit
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3361
#23 gtk_widget_size_allocate_with_baseline
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6093
#24 gtk_widget_size_allocate
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6162
#25 panel_toplevel_size_allocate
at panel-toplevel.c line 2823
#26 g_cclosure_marshal_VOID__BOXED
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gmarshal.c line 1910
#27 g_type_class_meta_marshal
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 961
#31 <emit signal ??? on instance 0x82144e8 [PanelToplevel]>
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3361
#32 gtk_widget_size_allocate_with_baseline
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6093
#33 gtk_widget_size_allocate
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkwidget.c line 6162
#34 panel_toplevel_check_resize
at panel-toplevel.c line 2684
#35 g_cclosure_marshal_VOID__VOIDv
#36 g_type_class_meta_marshalv
#37 _g_closure_invoke_va
#38 g_signal_emit_valist
#39 g_signal_emit
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3361
#40 gtk_container_check_resize
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkcontainer.c line 2041
#41 gtk_container_idle_sizer
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkcontainer.c line 1873
#42 g_cclosure_marshal_VOID__VOIDv
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gmarshal.c line 905
#43 _g_closure_invoke_va
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gclosure.c line 831
#44 g_signal_emit_valist
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3214
#45 g_signal_emit_by_name
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./gobject/gsignal.c line 3401
#46 gdk_frame_clock_paint_idle
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gdk/gdkframeclockidle.c line 408
#47 gdk_threads_dispatch
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gdk/gdk.c line 719
#48 g_timeout_dispatch
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./glib/gmain.c line 4545
#49 g_main_context_dispatch
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./glib/gmain.c line 3122
#50 g_main_context_dispatch
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./glib/gmain.c line 3737
#51 g_main_context_iterate
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./glib/gmain.c line 3808
#52 g_main_loop_run
at /build/glib2.0-ctZcLv/glib2.0-2.44.1/./glib/gmain.c line 4002
#53 gtk_main
at /build/gtk+3.0-Ntb7EA/gtk+3.0-3.16.4/./gtk/gtkmain.c line 1219
#54 main
at main.c line 164

Comment 1 Dmitry Shachnev 2015-06-16 17:06:52 UTC

I can reproduce it with bottom panel where the only widget is "Window list".

Comment 2 Alberts Muktupāvels 2015-06-19 21:36:26 UTC

Created attachment 305715 [details] [review]
panel-widget: update size hints in panel_widget_set_packed

Comment 3 Alberts Muktupāvels 2015-06-19 21:36:51 UTC

Please test this patch.

Comment 4 Dmitry Shachnev 2015-06-20 12:40:04 UTC

(In reply to Alberts Muktupāvels from comment #3)
> Please test this patch.

The patch works, thanks!