GNOME Bugzilla – Bug 750931
Add sound-name support to GtkNotificationDaemonNotification
Last modified: 2021-07-05 14:42:40 UTC
Created attachment 305228 [details] [review] Add sound-name support to GtkNotificationDaemonNotification To bring it up to feature parity with FdoNotificationDaemon. Related to my glib patch: bug 750926
(In reply to tingping from comment #0) > To bring it up to feature parity with FdoNotificationDaemon. For feature parity, there'd be quite a lot more to add, e.g. categories, capabilities, icon-actions, secondary images, ... However the goal of the GNotification API was never to replicate every single feature of the fd.o API, so those features were omitted on purpose. That doesn't mean that 'sound-name' support can't be added, but whether it should be is a question that needs answering first.
> For feature parity, there'd be quite a lot more to add Bad phrasing sorry. I meant that it would support every feature of the GNotification api including my linked glib patch.
The feature has been rejected in GIO, so doing the same here.
(In reply to Florian Müllner from comment #3) > The feature has been rejected in GIO, so doing the same here. Well Philip asked this regarding adding it to Gio so I wonder if you have any thoughts: > How does this fit in with the latest changes to > notifications in gnome-shell? I want to avoid adding new APIs piecemeal to > GNotification, in case they don’t fit in with the overall long-term plan for > notifications in the shell.
(In reply to Florian Müllner from comment #3) > The feature has been rejected in GIO, so doing the same here. Indeed, please don’t take its rejection from GIO as a sign that we’re not open to it in future. I’d like GIO to not be a leader with the API here, though — I’d like the drive to come from the shell, and how sounds fit in with its notifications design.
(In reply to Philip Withnall from comment #5) > I’d like the drive to come from the shell, and how sounds fit in > with its notifications design. I haven't been involved in the original design of the GNotification API, and as far as I know it was intentionally kept minimal at the beginning to build upon it. But: In the original design and implementation of notifications in gnome-shell, sound didn't play any role at all. That support was added much later and not driven by the design side, but rather because it was in the org.freedesktop.Notifications spec and someone wrote a patch. There have been two major notification redesigns since then, and none spent any thought on sounds, so IMHO it's safe to say that it's not in our plans, at least for now.
https://bugzilla.gnome.org/show_bug.cgi?id=793347 now exists and has some traction for the GLib/GIO side of things.
bug 750931 already had a patch, bug 793347 is just a duplicate.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.