GNOME Bugzilla – Bug 750869
dashdemux: assertion raised if profiles information is not provided
Last modified: 2015-10-29 11:04:07 UTC
Created attachment 305165 [details] [review] patch to fail the MPD parsing if profiles attribute is not provided g_strstr_len called from gst_mpd_client_check_profiles will raise an assert if profiles information was not provided: g_strstr_len: assertion 'haystack != NULL' failed Profiles is a mandatory attribute of the MPD and validation should fail if it is not provided.
Comment on attachment 305165 [details] [review] patch to fail the MPD parsing if profiles attribute is not provided Can we in theory work if no profile was provided, is there some sane default value we could use? If it's not too much effort we should try to handle malformed streams.
Created attachment 311125 [details] [review] do not dereference profiles if absent Absent profiles are ignored here (and profiles are currently ignored in the rest of the code already).
Created attachment 311126 [details] [review] Florin's unit test, with swapped error code Error code is swapped because no profile is now OK.
commit 5c8f7021166ba582eaf0cbca50e49d9e814b14a6 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Fri Sep 11 10:57:26 2015 +0100 mpdparser: do not dereference profiles is absent These are used to apply restrictions on what the MPD file may use, so no profile means no restrictions. Besides, nothing actually uses the profiles (yet) anyway. https://bugzilla.gnome.org/show_bug.cgi?id=750869
As well as: commit 84ff565c887b1d2df956328a4ae4ec19b2fdb4ee Author: Florin Apostol <florin.apostol@oregan.net> Date: Fri Sep 11 10:59:15 2015 +0100 dashdemux: unit test for missing profiles