After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750799 - datetime: Respect the date endianess
datetime: Respect the date endianess
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
unspecified
Other All
: Normal normal
: ---
Assigned To: Kalev Lember
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-11 15:39 UTC by Bastien Nocera
Modified: 2015-06-30 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
datetime: Respect the date endianess (21.22 KB, patch)
2015-06-11 15:39 UTC, Bastien Nocera
none Details | Review
datetime: Respect the date endianess (25.47 KB, patch)
2015-06-29 15:55 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2015-06-11 15:39:54 UTC
.
Comment 1 Bastien Nocera 2015-06-11 15:39:58 UTC
Created attachment 305078 [details] [review]
datetime: Respect the date endianess

When the user changes the date, order the widgets in the same order as
how the date is printed in that locale.
Comment 2 Mathieu Bridon 2015-06-11 15:44:12 UTC
Just tried it, works for me.

I don't feel very confident to judge on the quality of the code, though. :)
Comment 3 Rui Matos 2015-06-29 13:37:16 UTC
Review of attachment 305078 [details] [review]:

Not a fan of this approach with different .ui snippets for each order. Wouldn't a programatic juggling of the widgets be better? Also, this doesn't cover the just added YDM order which, again, seems like another reason for doing the ordering with code.
Comment 4 Bastien Nocera 2015-06-29 15:47:55 UTC
(In reply to Rui Matos from comment #3)
> Review of attachment 305078 [details] [review] [review]:
> 
> Not a fan of this approach with different .ui snippets for each order.
> Wouldn't a programatic juggling of the widgets be better?

I tried, and it was a pain in the neck.

> Also, this doesn't
> cover the just added YDM order which, again, seems like another reason for
> doing the ordering with code.

If you want to try with code, go for it, it ended up being too much for me.

I'll add support for ydm now though.
Comment 5 Bastien Nocera 2015-06-29 15:55:45 UTC
Created attachment 306305 [details] [review]
datetime: Respect the date endianess

When the user changes the date, order the widgets in the same order as
how the date is printed in that locale.
Comment 6 Rui Matos 2015-06-30 12:59:31 UTC
Review of attachment 306305 [details] [review]:

ok, let's go with this then