After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750714 - AllView: prevent accessing a NULL effect
AllView: prevent accessing a NULL effect
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 746312 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-06-10 14:20 UTC by Rui Matos
Modified: 2015-06-26 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
AllView: prevent accessing a NULL effect (1.25 KB, patch)
2015-06-10 14:20 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-06-10 14:20:50 UTC 
While playing around with screen rotation I noticed these stack
traces:

(gnome-shell:24655): Gjs-WARNING **: JS ERROR: Exception in callback for signal: allocated-size-changed: TypeError: this._scrollView.get_effect(...) is null
AllView<.adaptToSize@resource:///org/gnome/shell/ui/appDisplay.js:756
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
AppDisplay<._onAllocatedSizeChanged@resource:///org/gnome/shell/ui/appDisplay.js:1031
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_emit@resource:///org/gnome/gjs/modules/signals.js:124
ViewStackLayout<.vfunc_allocate@resource:///org/gnome/shell/ui/appDisplay.js:890
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_parent@resource:///org/gnome/gjs/modules/lang.js:131
ControlsLayout<.vfunc_allocate@resource:///org/gnome/shell/ui/overviewControls.js:400
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
LayoutManager<._init/<@resource:///org/gnome/shell/ui/layout.js:204
Comment 1 Rui Matos 2015-06-10 14:20:57 UTC 
Created attachment 304978 [details] [review]
AllView: prevent accessing a NULL effect

In some cases we might be allocated a size such that
this._grid.topPadding and this._grid.bottomPadding are both 0 which
means that the ScrollView fade effect gets removed. In that case don't
try to access the effect since it will be NULL.
Comment 2 Florian Müllner 2015-06-11 09:17:36 UTC 
*** Bug 746312 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2015-06-11 09:29:01 UTC 
Review of attachment 304978 [details] [review]:

OK
Comment 4 Rui Matos 2015-06-26 16:24:38 UTC 
Attachment 304978 [details] pushed as 7bdd1c6 - AllView: prevent accessing a NULL effect