After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750688 - tests: Run under Xvfb
tests: Run under Xvfb
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2015-06-10 08:32 UTC by Iain Lane
Modified: 2015-06-10 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Run under Xvfb (1.81 KB, patch)
2015-06-10 08:32 UTC, Iain Lane 		accepted-commit_now Details | Review

Description Iain Lane 2015-06-10 08:32:50 UTC 
With no display server running, the Gtk test fails

(/build/gjs-YHnosX/gjs-1.43.3/.libs/lt-jsunit:17796): Gtk-WARNING **: cannot open display: 
Terminated

I cribbed these rules from gtk3 to run the testsuite under Xvfb.
Comment 1 Iain Lane 2015-06-10 08:32:54 UTC 
Created attachment 304923 [details] [review]
tests: Run under Xvfb

To isolate from the user's X session, and also so that we work properly
in chroots or other minimal environments.
Comment 2 Colin Walters 2015-06-10 15:47:59 UTC 
Review of attachment 304923 [details] [review]:

At some point it'd be good to have this be an explicitly shared/shareable includeable Makefile-xfvb-utils.am or so, but for now, fine by me.

Note also https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests
Comment 3 Jasper St. Pierre (not reading bugmail) 2015-06-10 15:57:29 UTC 
Went ahead and pushed it. I think we hit the same issue at Endless. It's disappointing that our test suite now relies on GTK+ and X11, but c'est la vie I suppose.
Comment 4 Iain Lane 2015-06-10 16:17:02 UTC 
Thanks. It'd be good to have some kind of get-me-a-display-server thing that abstracts over X/Wayland(/Mir), I guess. And indeed, I think it's only the "Gtk" test that requires this - so that could be split out into its own binary.