Created attachment 304815 [details] [review]
Patch to fix FTBFS

xingmux.c fails to build with the following error log:

make[3]: Entering directory '/home/chris/rpm/BUILD/gst-plugins-ugly-1.5.1/gst/xingmux'
  CC       libgstxingmux_la-gstxingmux.lo
gstxingmux.c: In function 'generate_xing_header':
gstxingmux.c:320:24: error: 'rate' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     number_of_frames = gst_util_uint64_scale (duration, rate, GST_SECOND) / spf;
                        ^
gstxingmux.c:320:75: error: 'spf' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     number_of_frames = gst_util_uint64_scale (duration, rate, GST_SECOND) / spf;
                                                                           ^
gstxingmux.c:280:3: error: 'size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   } while (size < (4 + xing_offset + 4 + 4 + 4 + 4 + 100) && bitrate < 0xe);
   ^
cc1: all warnings being treated as errors
Makefile:615: recipe for target 'libgstxingmux_la-gstxingmux.lo' failed
make[3]: *** [libgstxingmux_la-gstxingmux.lo] Error 1
make[3]: Leaving directory '/home/chris/rpm/BUILD/gst-plugins-ugly-1.5.1/gst/xingmux'

The variables are initialized in parse_header(), but that function can return FALSE if errors occur, leaving the variables uninitialized. The build failure is fixed by returning NULL (from generate_xing_header() (where the build error occurs) when parse_header() return FALSE.

Patch attached for comment.