After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750470 - Only show titlebars under non-GNOME sessions
Only show titlebars under non-GNOME sessions
Status: RESOLVED NOTABUG
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-05 22:10 UTC by Jackson Doak
Modified: 2015-06-10 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable titlebars on !Gnome (935 bytes, patch)
2015-06-05 22:10 UTC, Jackson Doak 		none Details | Review

Description Jackson Doak 2015-06-05 22:10:11 UTC 
Created attachment 304673 [details] [review]
Disable titlebars on !Gnome

Titlebars don't work properly on !GNOME, so please only show them on GNOME. Many other gnome apps already carry patches to either use titlebars on only gnome or use titebars on !Unity (where the titlebars are most broken). Patch from ubuntu attached
Comment 1 Michael Catanzaro 2015-06-06 14:22:24 UTC 
Hm, Epiphany really needs the header bar, since one of the design requirements is to cut down on vertical space.

Typically when we merge these patches, we hide the header bar only in Unity and don't change anything for other desktops, not because this is the right thing to do, but to make it easier to update the Ubuntu packages for applications that you ship by default. But you don't ship Epiphany, you ship Firefox, so I don't see any point. (Plus, you don't keep up with our WebKit updates, so we wouldn't want to encourage users to use Epiphany on Ubuntu anyway: it's just not safe.)

I don't mind changing the UI in Unity only, if you're actually shipping our browser (you're not :) and really don't want the header bar, but we shouldn't change it for other desktops. GNOME is not magically the only place where header bars are appropriate: that is an upstream GTK+ thing. Also, if we hide the header bar, then we lose the nice home for the application menu for desktops that don't show it (everything besides GNOME and Ubuntu), which would be a bad regression in those desktops. Also, we use GtkHeaderBar unconditionally on every dialog we create, but you haven't changed that.
Comment 2 Michael Catanzaro 2015-06-10 12:24:17 UTC 
Going to close this so we don't have it open forever.