After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750410 - display: Don't show rotation for builtin display on tablets
display: Don't show rotation for builtin display on tablets
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-04 17:19 UTC by Bastien Nocera
Modified: 2015-06-08 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display: Don't show rotation for builtin display on tablets (6.33 KB, patch)
2015-06-04 17:19 UTC, Bastien Nocera 		none Details | Review
display: Don't show rotation for builtin display on tablets (6.33 KB, patch)
2015-06-08 13:08 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2015-06-04 17:19:19 UTC 
.
Comment 1 Bastien Nocera 2015-06-04 17:19:36 UTC 
Created attachment 304600 [details] [review]
display: Don't show rotation for builtin display on tablets

If there's an accelerometer builtin to the display, don't show the
rotation buttons, it will be handled by the user rotating the display,
eventually with the rotation lock in use.
Comment 2 Rui Matos 2015-06-08 12:40:33 UTC 
Review of attachment 304600 [details] [review]:

otherwise looks good

::: panels/display/cc-display-panel.c
@@ +2021,3 @@
+
+  /* Only offer rotation if there's no accelerometer */
+  return priv->has_accelerometer;

!priv->has_accelerometer ?
Comment 3 Bastien Nocera 2015-06-08 13:08:19 UTC 
Created attachment 304769 [details] [review]
display: Don't show rotation for builtin display on tablets

If there's an accelerometer builtin to the display, don't show the
rotation buttons, it will be handled by the user rotating the display,
eventually with the rotation lock in use.
Comment 4 Bastien Nocera 2015-06-08 13:10:51 UTC 
Attachment 304769 [details] pushed as b6d7bb8 - display: Don't show rotation for builtin display on tablets