Created attachment 304463 [details] [review]
split some code out into a comon function

this will looks cleaner and should making adding tiling easier.

Created attachment 304464 [details] [review]
use correctly typed pointer, just a small cleanup

Review of attachment 304463 [details] [review]:

looks like a good cleanup otherwise, thanks

::: panels/display/cc-display-panel.c
@@ +537,3 @@
       gtk_container_set_border_width (GTK_CONTAINER (item), 12);
 
+      get_geometry (output_info, &x, &y, &width, &height);

hmm, we were not (and still aren't) using any of these variables here, just remove them please

Review of attachment 304464 [details] [review]:

sure

Created attachment 305038 [details] [review]
split some code out into a common function (v2)

okay updated with removing the useless get_geometry call.

Review of attachment 305038 [details] [review]:

Looks good to me. Thanks, Dave. Could you please add the URL to this bug to the end of your commit message before pushing?

I don't have GNOME git access, so I require maintainers to push patches.

Comment on attachment 305038 [details] [review]
split some code out into a common function (v2)

Pushed to master.

Comment on attachment 304464 [details] [review]
use correctly typed pointer, just a small cleanup

Pushed to master.