GNOME Bugzilla – Bug 750287
Make OSK touch friendly (on wayland)
Last modified: 2015-06-04 11:22:54 UTC
We're currently only handling pointer events on OSK keys, which coincidentally works on X11 (as pointer events are emulated out of the XITouchEmulatingPointer touch sequence). This doesn't happen on wayland though, where touch is not expected to emulate pointer events. I'm attaching a patch (actually an older one revisited by rui/me) to handle touch events on wayland. This is left aside in X11 as there's weird interaction with the passive touch grab that don't make it as easy to obey one or the other, so it will be saner to stick to pointer-only events there.
Created attachment 304442 [details] [review] Revert "Revert "keyboard: Handle touch events"" And make these only handled on wayland. There's a plethora of issues around touch passive grab and touch/pointer doubly handling to use these right away on X11, so we stick to single-touch/pointer there. This reverts commit 032a688a72110c7f7b976a5b3bd03c3feab32646.
Review of attachment 304442 [details] [review]: Right, on X11 we'll keep working via the emulated pointer events for touch while on native ("wayland") where we just get touch events we can at least use the OSK. Please push for 3.16 as well
Review of attachment 304442 [details] [review]: ::: js/ui/keyboard.js @@ +120,3 @@ + let sequence = event.get_event_sequence(); + + if (!Meta.is_wayland_compositor()) A comment here would be nice.
(In reply to Jasper St. Pierre from comment #3) > Review of attachment 304442 [details] [review] [review]: > > ::: js/ui/keyboard.js > @@ +120,3 @@ > + let sequence = event.get_event_sequence(); > + > + if (!Meta.is_wayland_compositor()) > > A comment here would be nice. Sure, adding one and pushing.
Attachment 304442 [details] pushed as a7b0910 - Revert "Revert "keyboard: Handle touch events""
Can we also land this in GNOME 3.16? I can't login with the default GDM configuration (which uses Wayland), on a tablet. It worked in 3.14 when gdm used X11.