After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750267 - Show notification always when device is unmounted
Show notification always when device is unmounted
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: udisks2 volume monitor
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 587340 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-06-02 09:53 UTC by Ondrej Holy
Modified: 2016-01-04 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
monitor: Show notification always when device is unmounted (939 bytes, patch)
2015-06-02 09:53 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2015-06-02 09:53:59 UTC 
Created attachment 304418 [details] [review]
monitor: Show notification always when device is unmounted

Unmount progress is shown only when unmount takes more then 1.5 seconds. However the progress should be shown everytime when unmount is finished for users to be sure it is safe to remove device.

See downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1051858
Comment 1 Ross Lagerwall 2015-06-07 15:11:30 UTC 
Review of attachment 304418 [details] [review]:

Looks good!
Comment 2 Ondrej Holy 2015-06-08 09:01:05 UTC 
Comment on attachment 304418 [details] [review]
monitor: Show notification always when device is unmounted

Thanks for the review!

master:
commit 0f91898d0bc148ba0efa188d6798c3b5a780ab43

gnome-3-16:
commit 676ba166c0b7c69e65bce7f1ec5e38ac36ad33c8
Comment 3 Ondrej Holy 2016-01-04 09:32:37 UTC 
*** Bug 587340 has been marked as a duplicate of this bug. ***