After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749958 - Make the notifications list less chunky
Make the notifications list less chunky
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-27 12:20 UTC by Allan Day
Modified: 2015-08-05 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: Minor cleanup (1.35 KB, patch)
2015-08-05 15:18 UTC, Florian Müllner
committed Details | Review
calendar: Vertically center message icon rather than top-align it (957 bytes, patch)
2015-08-05 15:18 UTC, Florian Müllner
committed Details | Review
calendar: Tweak message list style (2.49 KB, patch)
2015-08-05 15:19 UTC, Florian Müllner
committed Details | Review

Description Allan Day 2015-05-27 12:20:29 UTC
The current notifications list is a bit on the chunky side. This means that it doesn't handle a lot of messages very well, and the calendar drop down can look a bit out of proportion.

Here's some guidance for an adjusted layout:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/notifications/redux/notification-list-layout.png
Comment 1 Florian Müllner 2015-08-05 15:18:46 UTC
Created attachment 308798 [details] [review]
calendar: Minor cleanup

Add a constant for the icon size used in message list entries rather
than hardcoding it twice.
Comment 2 Florian Müllner 2015-08-05 15:18:53 UTC
Created attachment 308799 [details] [review]
calendar: Vertically center message icon rather than top-align it

... as requested by the designers.
Comment 3 Florian Müllner 2015-08-05 15:19:01 UTC
Created attachment 308800 [details] [review]
calendar: Tweak message list style

* make icons smaller
 * use small font size in body
 * add some spacing between secondary item and title
Comment 4 Carlos Soriano 2015-08-05 15:22:16 UTC
Review of attachment 308798 [details] [review]:

LGTM
Comment 5 Carlos Soriano 2015-08-05 15:23:22 UTC
Review of attachment 308799 [details] [review]:

ok
Comment 6 Carlos Soriano 2015-08-05 15:30:11 UTC
Review of attachment 308800 [details] [review]:

missing gnome-shell-sass bump?
If not, LGTM
Comment 7 Carlos Soriano 2015-08-05 15:30:13 UTC
Review of attachment 308800 [details] [review]:

missing gnome-shell-sass bump?
If not, LGTM
Comment 8 Florian Müllner 2015-08-05 15:32:09 UTC
(In reply to Carlos Soriano from comment #6)
> missing gnome-shell-sass bump?

Yes, on purpose to make applying the patches easier - I'll include it when pushing of course.
Comment 9 Florian Müllner 2015-08-05 16:02:37 UTC
Attachment 308798 [details] pushed as be3d624 - calendar: Minor cleanup
Attachment 308799 [details] pushed as a343445 - calendar: Vertically center message icon rather than top-align it
Attachment 308800 [details] pushed as 11cbd39 - calendar: Tweak message list style