GNOME Bugzilla – Bug 749912
g_inet_address_new_from_string broken on XP/2003
Last modified: 2015-08-07 13:40:02 UTC
Since introduction of bug 730352, g_inet_address_new_from_string produces a GInetAddress instance that does not correspond to the given string.
Created attachment 304024 [details] [review] Proposed fix
Created attachment 304858 [details] [review] Fix a FIXME in the WinXP inet_pton() implementation ===== Can you verify that this patch works as well? (on top of your existing patch, not instead of it)
ACK, it also works in that case.
Attachment 304858 [details] pushed as f9af40a - Fix a FIXME in the WinXP inet_pton() implementation
can this patch be backported to 2.44 branch? thanks
(In reply to Nicola from comment #5) > can this patch be backported to 2.44 branch? thanks already done (675dbae3)
the second patch (the one you did) is missing in 2.44 branch, I pushed both to cerbero http://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=3021ad7f0c6cc33be424d5fbc95fa07812547fb1 and some gstreamer windows users confirmed that glib works fine on xp too, can you please push the second patch too?
That patch was just a code cleanup. Chun-wei's patch should fix the actual bug by itself.
Hi Dan, I think we still need the second patch in 2.44 (or at least have the g_hostname_is_ip_address() check in there), as my patch did not (yet) deal with the non-IP-address case (hence the XXX/Fixme) was still there, especially as 2.44 would be the last stable release series to support XP. I was trying to figure out the XXX/Fixme part myself, and did not realise the g_hostname_is_ip_address() part and was trying to go the long, long way :|. With blessings, thank you!
(In reply to Fan, Chun-wei from comment #9) > I think we still need the second patch in 2.44 ok, cherry-picked and pushed