After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749897 - network: Fix freeing const pointer
network: Fix freeing const pointer
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-26 11:34 UTC by Bastien Nocera
Modified: 2015-05-27 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Fix freeing const pointer (1.00 KB, patch)
2015-05-26 11:34 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2015-05-26 11:34:29 UTC 
.
Comment 1 Bastien Nocera 2015-05-26 11:34:33 UTC 
Created attachment 304000 [details] [review]
network: Fix freeing const pointer

From coverity:
gnome-control-center-3.14.5/panels/network/connection-editor/firewall-helpers.c:75:9: warning: passing argument 1 of 'g_free' discards 'const' qualifier from pointer target type [enabled by default]
Comment 2 Rui Matos 2015-05-26 16:44:54 UTC 
Review of attachment 304000 [details] [review]:

++
Comment 3 Bastien Nocera 2015-05-27 15:48:59 UTC 
Attachment 304000 [details] pushed as 3b283b7 - network: Fix freeing const pointer