After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749886 - Coverity scan bugs
Coverity scan bugs
Status: RESOLVED FIXED
Product: libdmapsharing
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: W. Michael Petullo
W. Michael Petullo
Depends on:
Blocks:
 
 
Reported: 2015-05-26 10:21 UTC by Bastien Nocera
Modified: 2015-06-01 01:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2015-05-26 10:21:18 UTC
libdmapsharing-2.9.30/libdmapsharing/dmap-gst-qt-input-stream.c:73: assign_zero: Assigning: "stream" = "NULL".
25. libdmapsharing-2.9.30/libdmapsharing/dmap-gst-qt-input-stream.c:129: var_deref_op: Dereferencing null pointer "stream".
#   127|   	gst_bin_add_many (GST_BIN (pipeline), src, decode, convert, audio_encode, mux, sink, NULL);
#   128|   
#   129|-> 	if (FALSE == gst_element_link (stream->priv->src, stream->priv->decode)) {
#   130|   		g_warning ("Error linking source and decode elements");
#   131|   		goto done;

libdmapsharing-2.9.30/libdmapsharing/daap-share.c:525: var_compare_op: Comparing "cd" to null implies that "cd" might be null.
17. libdmapsharing-2.9.30/libdmapsharing/daap-share.c:541: var_deref_op: Dereferencing null pointer "cd".
#   539|   	}
#   540|   	
#   541|-> 	if (NULL != cd->stream) {
#   542|   		g_input_stream_close (cd->stream, NULL, NULL);
#   543|   	}
Comment 1 W. Michael Petullo 2015-06-01 01:09:24 UTC
This should be fixed in 2.9.31. Thank you, Bastien!