GNOME Bugzilla – Bug 749867
Some limits are adjusted by arcane cylinder size amount when copying and resizing in a single operation
Last modified: 2015-08-03 17:30:44 UTC
There are some arcane adjustments when performing a combined copy into unallocated space and resize that copy as a single operation. 1) XFS minimum size is plus 2 * cylinder size. 2) When the available space is larger than the maximum size of the file system, the limit is the file system maximum size minus cylinder size. Get rid of these adjustments. Patches to follow in a while. Mike
That first sentence should have said: There are some arcane adjustments when performing a combined copy into unallocated space and resize as a single operation.
Created attachment 303971 [details] [review] Remove cylinder sized adjustments to resize limits (v1) Hi Curtis, While banging my head against the complexity of trying to understand how selected_partition member is used in Dialog_Base_Partition and Dialog_Partition_{Copy,New,Resize_Move} I saw this bit of old crud and decided I wanted an easy fix to do. Thanks, Mike
Hi Mike, Thanks for the detailed patch set in comment #2. I plan to review in-depth in the next few days. One question -- in one of the comments, the abbreviation "icw" is used. What does this represent? For example, icw some hacks in the other 2 Curtis
"icw" is actually part of the quoted commit summary written by Bart back in 2004. I think in this context it stood for "In Connection With". Mike
Thank you Mike for the clarification. That Three Letter Acronym (TLA) makes sense in this situation. :-) I reviewed the patch set in comment #2 and tested resizing and copying of xfs and ntfs file systems on kubuntu 12.04. All went well. I made two small changes to the comment in the second patch. 1) Change "and" to "an". From: This is probably and oversight To: This is probably an oversight 2) Remove duplicate "maximum". From: Remove this lower maximum maximum file system size To: Remove this lower maximum file system size The patch set in comment #2 has been committed to the git repository for inclusion in the next release of GParted. The relevant git commits can be viewed at the following links: Remove last trace of cylinder size adjustments in the resize dialog (#749867) https://git.gnome.org/browse/gparted/commit/?id=b9262922a76f985c0502adfa49dc974b5ae52097 Remove cylinder size adjustments in the copy dialog (#749867) https://git.gnome.org/browse/gparted/commit/?id=8bbb77f1f8c5d15ee2be9db6b69371452f7483d5
This enhancement was included in the GParted 0.23.0 release on August 3, 2015.