After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749823 - basetextoverlay: add properties for toggling drawing text shadow and outline
basetextoverlay: add properties for toggling drawing text shadow and outline
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-25 11:15 UTC by Lazar Claudiu
Modified: 2015-06-14 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add draw-shadow and draw-outline properties (12.73 KB, patch)
2015-05-25 11:16 UTC, Lazar Claudiu 		none Details | Review
Removed indents from header (5.48 KB, patch)
2015-05-26 09:01 UTC, Lazar Claudiu 		none Details | Review
Fixed author and header indents (5.49 KB, patch)
2015-05-26 09:28 UTC, Lazar Claudiu 		committed Details | Review

Description Lazar Claudiu 2015-05-25 11:15:45 UTC 
Currently shadow and outline drawing is hardcoded and impossible to switch off.

This affects users who have to control the aesthetics of their text overlays.
Comment 1 Lazar Claudiu 2015-05-25 11:16:28 UTC 
Created attachment 303912 [details] [review]
Add draw-shadow and draw-outline properties
Comment 2 Tim-Philipp Müller 2015-05-26 08:22:36 UTC 
Comment on attachment 303912 [details] [review]
Add draw-shadow and draw-outline properties

We only indent .c files, not header files. Could you please make a patch that doesn't re-indent the entire header?
Comment 3 Lazar Claudiu 2015-05-26 09:01:49 UTC 
Created attachment 303973 [details] [review]
Removed indents from header
Comment 4 Lazar Claudiu 2015-05-26 09:28:00 UTC 
Created attachment 303976 [details] [review]
Fixed author and header indents
Comment 5 Tim-Philipp Müller 2015-06-14 16:58:08 UTC 
Pushed with minor changes (renamed PROP_OUTLINE|SHADOW to PROP_DRAW_OUTLINE|SHADOW; added Since: 1.6 markers to properties' gtk-doc chunks), thanks for the patch:

commit f5906122fbddbbad446a6c25355d8d954d4c58bb
Author: Lazar Claudiu <lazar.claudiu.florin@gmail.com>
Date:   Wed May 27 12:20:19 2015 +0300

    basetextoverlay: add "draw-shadow" and "draw-outline" properties
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749823