After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749706 - .gitignore files should not be under version control
.gitignore files should not be under version control
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal minor
: 1.24
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-22 00:33 UTC by Michael Catanzaro
Modified: 2015-05-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix .gitignores (16.18 KB, patch)
2015-05-22 00:35 UTC, Michael Catanzaro 		committed Details | Review
Fix .gitignores (21.34 KB, patch)
2015-05-22 11:11 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Michael Catanzaro 2015-05-22 00:33:04 UTC 
The .gitignore files are generated and should not be under version control.
Comment 1 Michael Catanzaro 2015-05-22 00:35:00 UTC 
Created attachment 303790 [details] [review]
Fix .gitignores

I feel like INSTALL should not need to have been listed under MAINTAINERCLEANFILES as I've made commits like this several times before without having any troubles from INSTALL, but it was not being ignored otherwise....
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2015-05-22 11:11:16 UTC 
The following fix has been pushed:
b6f0a1f Fix .gitignores
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2015-05-22 11:11:24 UTC 
Created attachment 303814 [details] [review]
Fix .gitignores

Don't put .gitignore files under version control: they're generated by
git.mk.

Update git.mk and hook it up in Makefile.am.

Update remaining Makefile.am to get to a clean git status.

Don't clean/ignore files in $(srcdir) -- this makes no sense because
only generated files should be ignored, and generated files should be
generated in $(builddir).
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2015-05-22 11:59:16 UTC 
Thanks, I've expanded your patch a bit and now it looks wonderfully clean!